Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2142743002: Stop tracking user input events without a relevant load. (Closed)

Created:
4 years, 5 months ago by Bryan McQuade
Modified:
4 years, 5 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, mushan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop tracking user input events without a relevant load. These events are 100x more common than other errors. User input events can arrive when the user is e.g. looking at an image, which isn't a tracked page but is something a user can interact with, so it's valid to receive input events without a committed load. Thus, it doesn't make sense to log this error. Committed: https://crrev.com/627da0d739730f909ed9fa94f20cb227eb4e4a1c Cr-Commit-Position: refs/heads/master@{#405286}

Patch Set 1 #

Patch Set 2 : comment fix #

Patch Set 3 : update comment #

Patch Set 4 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M components/page_load_metrics/browser/metrics_web_contents_observer.h View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M components/page_load_metrics/browser/metrics_web_contents_observer.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Bryan McQuade
PTAL
4 years, 5 months ago (2016-07-12 16:51:18 UTC) #2
Charlie Harrison
lgtm
4 years, 5 months ago (2016-07-12 18:52:01 UTC) #3
mushan
lgtm
4 years, 5 months ago (2016-07-13 01:59:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142743002/60001
4 years, 5 months ago (2016-07-13 18:24:38 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-13 21:25:21 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 21:25:42 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 21:28:12 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/627da0d739730f909ed9fa94f20cb227eb4e4a1c
Cr-Commit-Position: refs/heads/master@{#405286}

Powered by Google App Engine
This is Rietveld 408576698