Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2821)

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 2142743002: Stop tracking user input events without a relevant load. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/page_load_metrics/browser/metrics_web_contents_observer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/page_load_metrics/browser/metrics_web_contents_observer.cc
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
index 5009703a5e7ab0b092cd7ceaa59e0657cd4547b3..c9896b7d5e9aaa7fe08705a332477d05175d29cf 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
@@ -786,12 +786,8 @@ void MetricsWebContentsObserver::OnInputEvent(
if (event.type == blink::WebInputEvent::Type::Undefined)
return;
- if (!committed_load_) {
- RecordInternalError(ERR_USER_INPUT_WITH_NO_RELEVANT_LOAD);
- return;
- }
-
- committed_load_->OnInputEvent(event);
+ if (committed_load_)
+ committed_load_->OnInputEvent(event);
}
void MetricsWebContentsObserver::DidRedirectNavigation(
« no previous file with comments | « components/page_load_metrics/browser/metrics_web_contents_observer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698