Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: components/page_load_metrics/browser/metrics_web_contents_observer.h

Issue 2142743002: Stop tracking user input events without a relevant load. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_ 5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_
6 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_ 6 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <vector> 10 #include <vector>
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 // cc file for details). We use this error counter to understand how often it 82 // cc file for details). We use this error counter to understand how often it
83 // happens. 83 // happens.
84 ERR_ABORT_BEFORE_NAVIGATION_START, 84 ERR_ABORT_BEFORE_NAVIGATION_START,
85 85
86 // A new navigation triggers abort updates in multiple trackers in 86 // A new navigation triggers abort updates in multiple trackers in
87 // |aborted_provisional_loads_|, when usually there should only be one (the 87 // |aborted_provisional_loads_|, when usually there should only be one (the
88 // navigation that just aborted because of this one). If this happens, the 88 // navigation that just aborted because of this one). If this happens, the
89 // latest aborted load is used to track the chain size. 89 // latest aborted load is used to track the chain size.
90 ERR_NAVIGATION_SIGNALS_MULIPLE_ABORTED_LOADS, 90 ERR_NAVIGATION_SIGNALS_MULIPLE_ABORTED_LOADS,
91 91
92 // Receives user input before navigation start 92 // Received user input without a relevant load. This error type is deprecated,
93 ERR_USER_INPUT_WITH_NO_RELEVANT_LOAD, 93 // as it is valid to receive user input without a relevant load. We leave the
94 // enum value here since it's also used in histogram recording, so it's
95 // important that we not re-use this enum entry for a different value.
96 DEPRECATED_ERR_USER_INPUT_WITH_NO_RELEVANT_LOAD,
94 97
95 // A TimeTicks value in the browser process has value less than 98 // A TimeTicks value in the browser process has value less than
96 // navigation_start_. This could happen if navigation_start_ was computed in 99 // navigation_start_. This could happen if navigation_start_ was computed in
97 // renderer process and the system clock has inter process time tick skew. 100 // renderer process and the system clock has inter process time tick skew.
98 ERR_INTER_PROCESS_TIME_TICK_SKEW, 101 ERR_INTER_PROCESS_TIME_TICK_SKEW,
99 102
100 // Add values before this final count. 103 // Add values before this final count.
101 ERR_LAST_ENTRY, 104 ERR_LAST_ENTRY,
102 }; 105 };
103 106
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 345
343 // Has the MWCO observed at least one navigation? 346 // Has the MWCO observed at least one navigation?
344 bool has_navigated_; 347 bool has_navigated_;
345 348
346 DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver); 349 DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver);
347 }; 350 };
348 351
349 } // namespace page_load_metrics 352 } // namespace page_load_metrics
350 353
351 #endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_ 354 #endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_
OLDNEW
« no previous file with comments | « no previous file | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698