Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2142363002: Updating GetChannel in BlimpMetricsServiceClient so metrics will display (Closed)

Created:
4 years, 5 months ago by Jess
Modified:
4 years, 5 months ago
Reviewers:
skare_, *Wez, vadim
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating GetChannel in BlimpMetricsServiceClient so metrics will display properly in tools. Currently the metrics can only be viewed in a subset of tool displays due to the channel field having a value of CHANNEL_UNKNOWN. Metrics with UNKNOWN channel are filtered by default as unofficial builds. BUG=592757 Committed: https://crrev.com/cf31b77907bb3968b51a6c44c421dcca671adbbc Cr-Commit-Position: refs/heads/master@{#405398}

Patch Set 1 #

Patch Set 2 : Addendum to comment on metrics channel. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M blimp/engine/app/blimp_metrics_service_client.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Jess
For the service side investigation that lead to this change please see: https://b.corp.google.com/u/0/issues/28975618
4 years, 5 months ago (2016-07-13 20:24:16 UTC) #4
skare_
lgtm
4 years, 5 months ago (2016-07-13 20:34:15 UTC) #5
Wez
lgtm
4 years, 5 months ago (2016-07-14 01:21:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142363002/20001
4 years, 5 months ago (2016-07-14 01:22:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 01:58:30 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 01:59:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf31b77907bb3968b51a6c44c421dcca671adbbc
Cr-Commit-Position: refs/heads/master@{#405398}

Powered by Google App Engine
This is Rietveld 408576698