Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: blimp/engine/app/blimp_metrics_service_client.cc

Issue 2142363002: Updating GetChannel in BlimpMetricsServiceClient so metrics will display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addendum to comment on metrics channel. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/engine/app/blimp_metrics_service_client.h" 5 #include "blimp/engine/app/blimp_metrics_service_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/i18n/rtl.h" 8 #include "base/i18n/rtl.h"
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 std::string BlimpMetricsServiceClient::GetApplicationLocale() { 111 std::string BlimpMetricsServiceClient::GetApplicationLocale() {
112 return base::i18n::GetConfiguredLocale(); 112 return base::i18n::GetConfiguredLocale();
113 } 113 }
114 114
115 bool BlimpMetricsServiceClient::GetBrand(std::string* brand_code) { 115 bool BlimpMetricsServiceClient::GetBrand(std::string* brand_code) {
116 // Blimp doesn't use brand codes. 116 // Blimp doesn't use brand codes.
117 return false; 117 return false;
118 } 118 }
119 119
120 metrics::SystemProfileProto::Channel BlimpMetricsServiceClient::GetChannel() { 120 metrics::SystemProfileProto::Channel BlimpMetricsServiceClient::GetChannel() {
121 // Blimp engine does not have channel info yet. 121 // Blimp engine does not have channel info yet, however metrics data with
122 return metrics::SystemProfileProto::CHANNEL_UNKNOWN; 122 // CHANNEL_UNKNOWN is filtered in metrics visualization tools since the value
123 // typically implies a non-official build.
124 // Using CHANNEL_CANARY as a work around until channel is set here.
125 return metrics::SystemProfileProto::CHANNEL_CANARY;
123 } 126 }
124 127
125 std::string BlimpMetricsServiceClient::GetVersionString() { 128 std::string BlimpMetricsServiceClient::GetVersionString() {
126 return version_info::GetVersionNumber(); 129 return version_info::GetVersionNumber();
127 } 130 }
128 131
129 void BlimpMetricsServiceClient::OnLogUploadComplete() {} 132 void BlimpMetricsServiceClient::OnLogUploadComplete() {}
130 133
131 void BlimpMetricsServiceClient::InitializeSystemProfileMetrics( 134 void BlimpMetricsServiceClient::InitializeSystemProfileMetrics(
132 const base::Closure& done_callback) { 135 const base::Closure& done_callback) {
(...skipping 26 matching lines...) Expand all
159 BlimpMetricsServiceClient::GetMetricsReportingDefaultState() { 162 BlimpMetricsServiceClient::GetMetricsReportingDefaultState() {
160 return metrics::EnableMetricsDefault::OPT_IN; 163 return metrics::EnableMetricsDefault::OPT_IN;
161 } 164 }
162 165
163 bool BlimpMetricsServiceClient::IsConsentGiven() { 166 bool BlimpMetricsServiceClient::IsConsentGiven() {
164 return true; 167 return true;
165 } 168 }
166 169
167 } // namespace engine 170 } // namespace engine
168 } // namespace blimp 171 } // namespace blimp
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698