Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3170)

Unified Diff: blimp/engine/app/blimp_metrics_service_client.cc

Issue 2142363002: Updating GetChannel in BlimpMetricsServiceClient so metrics will display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addendum to comment on metrics channel. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/app/blimp_metrics_service_client.cc
diff --git a/blimp/engine/app/blimp_metrics_service_client.cc b/blimp/engine/app/blimp_metrics_service_client.cc
index 019e54d3d2ebb735c6f1e320c7182809a87d87ee..6149b5a333eab772900fc8cf32679a358101c0fe 100644
--- a/blimp/engine/app/blimp_metrics_service_client.cc
+++ b/blimp/engine/app/blimp_metrics_service_client.cc
@@ -118,8 +118,11 @@ bool BlimpMetricsServiceClient::GetBrand(std::string* brand_code) {
}
metrics::SystemProfileProto::Channel BlimpMetricsServiceClient::GetChannel() {
- // Blimp engine does not have channel info yet.
- return metrics::SystemProfileProto::CHANNEL_UNKNOWN;
+ // Blimp engine does not have channel info yet, however metrics data with
+ // CHANNEL_UNKNOWN is filtered in metrics visualization tools since the value
+ // typically implies a non-official build.
+ // Using CHANNEL_CANARY as a work around until channel is set here.
+ return metrics::SystemProfileProto::CHANNEL_CANARY;
}
std::string BlimpMetricsServiceClient::GetVersionString() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698