Remove ContentViewCore dependency from OverlayPanel

Remove ContentViewCore dependency from OverlayPanel

The only reason ContentViewCore is passed to the OverlayPanels is to
get the cc::Layer containing the content. This change removes the
dependency on ContentViewCore from the native OverlayPanel layers
in favor of the cc::Layer obtained from WebContents.

BUG=626848
Committed: https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2
Cr-Commit-Position: refs/heads/master@{#405360}

[mdjones, 2016-07-12 22:21:48]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2016-07-12 22:21:48]

ptal

[no sievers, 2016-07-12 23:44:15]

sievers@chromium.org changed reviewers:
+ sievers@chromium.org

[no sievers, 2016-07-12 23:44:16]

lgtm w/nits. thanks!

https://codereview.chromium.org/2142263002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java
(right):

https://codereview.chromium.org/2142263002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java:109:
WebContents panelWebContents = panel.getContentViewCore() != null
hmm how do you get away with not importing CVC? :)

https://codereview.chromium.org/2142263002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java:224:
WebContents contentViewCore,
nit: s/contentViewCore/webContents

https://codereview.chromium.org/2142263002/diff/1/chrome/browser/android/comp...
File chrome/browser/android/compositor/layer/contextual_search_layer.h (right):

https://codereview.chromium.org/2142263002/diff/1/chrome/browser/android/comp...
chrome/browser/android/compositor/layer/contextual_search_layer.h:52:
scoped_refptr<cc::Layer> content_layer,
nit: scoped_refptr const-ref here and elsewhere

[mdjones, 2016-07-13 00:21:31]

https://codereview.chromium.org/2142263002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java
(right):

https://codereview.chromium.org/2142263002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java:109:
WebContents panelWebContents = panel.getContentViewCore() != null
On 2016/07/12 23:44:16, sievers wrote:
> hmm how do you get away with not importing CVC? :)

Java black magic :). If you don't have an explicit reference, you don't have to
import it (unlike c++).

https://codereview.chromium.org/2142263002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java:224:
WebContents contentViewCore,
On 2016/07/12 23:44:16, sievers wrote:
> nit: s/contentViewCore/webContents

Done.

https://codereview.chromium.org/2142263002/diff/1/chrome/browser/android/comp...
File chrome/browser/android/compositor/layer/contextual_search_layer.h (right):

https://codereview.chromium.org/2142263002/diff/1/chrome/browser/android/comp...
chrome/browser/android/compositor/layer/contextual_search_layer.h:52:
scoped_refptr<cc::Layer> content_layer,
On 2016/07/12 23:44:16, sievers wrote:
> nit: scoped_refptr const-ref here and elsewhere

Done.

[Theresa, 2016-07-13 00:25:16]

lgtm

[mdjones, 2016-07-13 00:59:29]

mdjones@chromium.org changed reviewers:
+ dtrainor@chromium.org

[mdjones, 2016-07-13 00:59:29]

+dtrainor for owners

[David Trainor- moved to gerrit, 2016-07-13 19:59:34]

lgtm thanks!

[mdjones, 2016-07-13 22:41:20]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-07-13 22:41:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2142263002/#ps40001
(title: "var name")

[commit-bot: I haz the power, 2016-07-13 22:43:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 00:17:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 00:17:55]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 00:20:03]

Description was changed from

==========
Remove ContentViewCore dependency from OverlayPanel

The only reason ContentViewCore is passed to the OverlayPanels is to
get the cc::Layer containing the content. This change removes the
dependency on ContentViewCore from the native OverlayPanel layers
in favor of the cc::Layer obtained from WebContents.

BUG=626848
==========

to

==========
Remove ContentViewCore dependency from OverlayPanel

The only reason ContentViewCore is passed to the OverlayPanels is to
get the cc::Layer containing the content. This change removes the
dependency on ContentViewCore from the native OverlayPanel layers
in favor of the cc::Layer obtained from WebContents.

BUG=626848

Committed: https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2
Cr-Commit-Position: refs/heads/master@{#405360}
==========

[commit-bot: I haz the power, 2016-07-14 00:20:04]

Patchset 3 (id:??) landed as
https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2
Cr-Commit-Position: refs/heads/master@{#405360}