Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2113)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java

Issue 2142263002: Remove ContentViewCore dependency from OverlayPanel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: var name Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ReaderModeSceneLayer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java
index 74367d929360748f74ce1d369684bd5d559525ac..7a3c79d205e303453798c7ca52d633efbd355df9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java
@@ -11,7 +11,7 @@ import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.Context
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPeekPromoControl;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPromoControl;
-import org.chromium.content.browser.ContentViewCore;
+import org.chromium.content_public.browser.WebContents;
import org.chromium.ui.resources.ResourceManager;
/**
@@ -106,6 +106,9 @@ public class ContextualSearchSceneLayer extends SceneOverlayLayer {
float progressBarOpacity = panel.getProgressBarOpacity();
int progressBarCompletion = panel.getProgressBarCompletion();
+ WebContents panelWebContents = panel.getContentViewCore() != null
+ ? panel.getContentViewCore().getWebContents() : null;
+
nativeUpdateContextualSearchLayer(mNativePtr,
R.drawable.contextual_search_bar_background,
searchContextViewId,
@@ -124,7 +127,7 @@ public class ContextualSearchSceneLayer extends SceneOverlayLayer {
mDpToPx,
panel.getBasePageBrightness(),
panel.getBasePageY() * mDpToPx,
- panel.getContentViewCore(),
+ panelWebContents,
searchPromoVisible,
searchPromoHeightPx,
searchPromoOpacity,
@@ -218,7 +221,7 @@ public class ContextualSearchSceneLayer extends SceneOverlayLayer {
float dpToPx,
float basePageBrightness,
float basePageYOffset,
- ContentViewCore contentViewCore,
+ WebContents webContents,
boolean searchPromoVisible,
float searchPromoHeight,
float searchPromoOpacity,
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ReaderModeSceneLayer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698