chrome/browser/android/compositor/layer/reader_mode_layer.cc - Issue 2142263002: Remove ContentViewCore dependency from OverlayPanel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/layer/reader_mode_layer.cc

Issue 2142263002: Remove ContentViewCore dependency from OverlayPanel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: var name Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/compositor/layer/reader_mode_layer.h ('k') | chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/compositor/layer/reader_mode_layer.cc

diff --git a/chrome/browser/android/compositor/layer/reader_mode_layer.cc b/chrome/browser/android/compositor/layer/reader_mode_layer.cc

index 68690af9bcf185898035e1ceb238b5e67f9a3bd6..b55d21ce2dbb8d861227af8dcf03af385b2a4c8e 100644

--- a/chrome/browser/android/compositor/layer/reader_mode_layer.cc

+++ b/chrome/browser/android/compositor/layer/reader_mode_layer.cc

@@ -7,7 +7,6 @@

#include "cc/layers/layer.h"

#include "cc/resources/scoped_ui_resource.h"

#include "content/public/browser/android/compositor.h"

-#include "content/public/browser/android/content_view_core.h"

#include "ui/android/resources/resource_manager.h"

namespace chrome {

@@ -21,7 +20,7 @@ scoped_refptr<ReaderModeLayer> ReaderModeLayer::Create(

void ReaderModeLayer::SetProperties(

float dp_to_px,

- content::ContentViewCore* content_view_core,

+ const scoped_refptr<cc::Layer>& content_layer,

float panel_x,

float panel_y,

float panel_width,

@@ -38,7 +37,7 @@ void ReaderModeLayer::SetProperties(

OverlayPanelLayer::SetProperties(

dp_to_px,

- content_view_core,

+ content_layer,

bar_height,

panel_x,

panel_y,