Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2141993002: Remove many-many SpdyMajorVersion and NextProto arguments and members. (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove many-many SpdyMajorVersion and NextProto arguments and members. Now that SPDY/3.1 is disabled, rip it out from more areas of the code: Remove SpdyMajorVersion and NextProto members, accessors, and function arguments from BufferedSpdyFramer, SpdySession, SpdySessionPool, HeaderCoalescer, SpdyStream classes, from spdy_http_utils.{h,cc}, and from flipserver. Also deprecate Net.SpdySettingsCwndSent and Net.SpdyVersion3 histograms. BUG=624095 Committed: https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e Cr-Commit-Position: refs/heads/master@{#405481}

Patch Set 1 #

Patch Set 2 : Remove unnecessary next_proto.h includes. #

Patch Set 3 : Remove OnSynStream() and OnSynReply(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -1052 lines) Patch
M net/http/bidirectional_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/bidirectional_stream_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/bidirectional_stream_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/bidirectional_stream_quic_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/quic_http_stream.cc View 1 4 chunks +3 lines, -5 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/buffered_spdy_framer.h View 1 2 5 chunks +1 line, -21 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 2 10 chunks +9 lines, -60 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 1 2 12 chunks +7 lines, -39 lines 0 comments Download
M net/spdy/header_coalescer.h View 2 chunks +1 line, -4 lines 0 comments Download
M net/spdy/header_coalescer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_http_stream.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 1 10 chunks +4 lines, -12 lines 0 comments Download
M net/spdy/spdy_http_utils.h View 2 chunks +5 lines, -11 lines 0 comments Download
M net/spdy/spdy_http_utils.cc View 5 chunks +17 lines, -66 lines 0 comments Download
M net/spdy/spdy_http_utils_unittest.cc View 6 chunks +17 lines, -68 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 13 chunks +16 lines, -21 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/spdy/spdy_session.h View 1 2 9 chunks +4 lines, -37 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 27 chunks +58 lines, -300 lines 0 comments Download
M net/spdy/spdy_session_pool.h View 4 chunks +1 line, -8 lines 0 comments Download
M net/spdy/spdy_session_pool.cc View 4 chunks +2 lines, -12 lines 0 comments Download
M net/spdy/spdy_session_pool_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 26 chunks +20 lines, -72 lines 0 comments Download
M net/spdy/spdy_stream.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/spdy/spdy_stream.cc View 3 chunks +1 line, -9 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 2 8 chunks +6 lines, -21 lines 0 comments Download
M net/tools/flip_server/sm_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/flip_server/sm_connection.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M net/tools/flip_server/spdy_interface.h View 1 2 4 chunks +2 lines, -19 lines 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 1 2 3 chunks +4 lines, -49 lines 0 comments Download
M net/tools/flip_server/spdy_interface_test.cc View 1 2 18 chunks +26 lines, -156 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_client.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Bence
Ryan, PTAL. Thank you.
4 years, 5 months ago (2016-07-12 20:56:43 UTC) #2
Ryan Hamilton
lgtm
4 years, 5 months ago (2016-07-12 22:06:08 UTC) #3
Bence
Ilya: PTAL at tools/metrics/histograms/. Thank you.
4 years, 5 months ago (2016-07-13 11:58:02 UTC) #5
Ilya Sherman
histograms.xml lgtm, thanks!
4 years, 5 months ago (2016-07-13 23:58:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141993002/40001
4 years, 5 months ago (2016-07-14 11:56:50 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-14 13:06:17 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 13:06:25 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 13:07:19 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bca843ba1471a6ca4eaf9f6869153389de683d6e
Cr-Commit-Position: refs/heads/master@{#405481}

Powered by Google App Engine
This is Rietveld 408576698