Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: net/spdy/spdy_http_stream_unittest.cc

Issue 2141993002: Remove many-many SpdyMajorVersion and NextProto arguments and members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove OnSynStream() and OnSynReply(). Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_http_stream.cc ('k') | net/spdy/spdy_http_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_http_stream_unittest.cc
diff --git a/net/spdy/spdy_http_stream_unittest.cc b/net/spdy/spdy_http_stream_unittest.cc
index c1c0084819b2dc9e3705d2ee3a9834c74464d482..36115dc69931c3a20c0e1f8927394485df1f556b 100644
--- a/net/spdy/spdy_http_stream_unittest.cc
+++ b/net/spdy/spdy_http_stream_unittest.cc
@@ -22,7 +22,6 @@
#include "net/http/http_response_headers.h"
#include "net/http/http_response_info.h"
#include "net/log/test_net_log.h"
-#include "net/socket/next_proto.h"
#include "net/socket/socket_test_util.h"
#include "net/spdy/spdy_http_utils.h"
#include "net/spdy/spdy_session.h"
@@ -347,7 +346,7 @@ TEST_P(SpdyHttpStreamTest, LoadTimingTwoRequests) {
}
TEST_P(SpdyHttpStreamTest, SendChunkedPost) {
- BufferedSpdyFramer framer(HTTP2);
+ BufferedSpdyFramer framer;
std::unique_ptr<SpdySerializedFrame> req(
spdy_util_.ConstructChunkedSpdyPost(nullptr, 0));
@@ -367,7 +366,6 @@ TEST_P(SpdyHttpStreamTest, SendChunkedPost) {
};
InitSession(reads, arraysize(reads), writes, arraysize(writes));
- EXPECT_EQ(HTTP2, session_->GetProtocolVersion());
ChunkedUploadDataStream upload_stream(0);
const int kFirstChunkSize = kUploadDataSize/2;
@@ -428,7 +426,6 @@ TEST_P(SpdyHttpStreamTest, SendChunkedPostLastEmpty) {
};
InitSession(reads, arraysize(reads), writes, arraysize(writes));
- EXPECT_EQ(HTTP2, session_->GetProtocolVersion());
ChunkedUploadDataStream upload_stream(0);
upload_stream.AppendData(nullptr, 0, true);
@@ -464,7 +461,7 @@ TEST_P(SpdyHttpStreamTest, SendChunkedPostLastEmpty) {
}
TEST_P(SpdyHttpStreamTest, ConnectionClosedDuringChunkedPost) {
- BufferedSpdyFramer framer(HTTP2);
+ BufferedSpdyFramer framer;
std::unique_ptr<SpdySerializedFrame> req(
spdy_util_.ConstructChunkedSpdyPost(nullptr, 0));
@@ -482,7 +479,6 @@ TEST_P(SpdyHttpStreamTest, ConnectionClosedDuringChunkedPost) {
};
InitSession(reads, arraysize(reads), writes, arraysize(writes));
- EXPECT_EQ(HTTP2, session_->GetProtocolVersion());
ChunkedUploadDataStream upload_stream(0);
// Append first chunk.
@@ -904,8 +900,7 @@ TEST_P(SpdyHttpStreamTest, DelayedSendChunkedPostWithWindowUpdate) {
// Verify that the window size has decreased.
ASSERT_TRUE(http_stream->stream() != nullptr);
- EXPECT_NE(static_cast<int>(
- SpdySession::GetDefaultInitialWindowSize(session_->protocol())),
+ EXPECT_NE(static_cast<int>(kDefaultInitialWindowSize),
http_stream->stream()->send_window_size());
// Read window update.
@@ -918,8 +913,7 @@ TEST_P(SpdyHttpStreamTest, DelayedSendChunkedPostWithWindowUpdate) {
// Verify the window update.
ASSERT_TRUE(http_stream->stream() != nullptr);
- EXPECT_EQ(static_cast<int>(
- SpdySession::GetDefaultInitialWindowSize(session_->protocol())),
+ EXPECT_EQ(static_cast<int>(kDefaultInitialWindowSize),
http_stream->stream()->send_window_size());
// Read rest of data.
@@ -968,7 +962,6 @@ TEST_P(SpdyHttpStreamTest, DataReadErrorSynchronous) {
};
InitSession(reads, arraysize(reads), writes, arraysize(writes));
- EXPECT_EQ(HTTP2, session_->GetProtocolVersion());
ReadErrorUploadDataStream upload_data_stream(
ReadErrorUploadDataStream::FailureMode::SYNC);
@@ -1019,7 +1012,6 @@ TEST_P(SpdyHttpStreamTest, DataReadErrorAsynchronous) {
};
InitSession(reads, arraysize(reads), writes, arraysize(writes));
- EXPECT_EQ(HTTP2, session_->GetProtocolVersion());
ReadErrorUploadDataStream upload_data_stream(
ReadErrorUploadDataStream::FailureMode::ASYNC);
« no previous file with comments | « net/spdy/spdy_http_stream.cc ('k') | net/spdy/spdy_http_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698