Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: net/socket/ssl_client_socket_pool_unittest.cc

Issue 2141993002: Remove many-many SpdyMajorVersion and NextProto arguments and members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove OnSynStream() and OnSynReply(). Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_http_stream.cc ('k') | net/spdy/bidirectional_stream_spdy_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_proxy_client_socket_pool.h" 5 #include "net/http/http_proxy_client_socket_pool.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 // None of these tests use a NetLog. 73 // None of these tests use a NetLog.
74 EXPECT_EQ(NetLog::Source::kInvalidId, load_timing_info.socket_log_id); 74 EXPECT_EQ(NetLog::Source::kInvalidId, load_timing_info.socket_log_id);
75 75
76 EXPECT_FALSE(load_timing_info.socket_reused); 76 EXPECT_FALSE(load_timing_info.socket_reused);
77 77
78 ExpectConnectTimingHasTimes(load_timing_info.connect_timing, 78 ExpectConnectTimingHasTimes(load_timing_info.connect_timing,
79 CONNECT_TIMING_HAS_SSL_TIMES); 79 CONNECT_TIMING_HAS_SSL_TIMES);
80 ExpectLoadTimingHasOnlyConnectionTimes(load_timing_info); 80 ExpectLoadTimingHasOnlyConnectionTimes(load_timing_info);
81 } 81 }
82 82
83 class SSLClientSocketPoolTest 83 class SSLClientSocketPoolTest : public testing::Test {
84 : public testing::Test,
85 public ::testing::WithParamInterface<NextProto> {
86 protected: 84 protected:
87 SSLClientSocketPoolTest() 85 SSLClientSocketPoolTest()
88 : cert_verifier_(new MockCertVerifier), 86 : cert_verifier_(new MockCertVerifier),
89 transport_security_state_(new TransportSecurityState), 87 transport_security_state_(new TransportSecurityState),
90 proxy_service_(ProxyService::CreateDirect()), 88 proxy_service_(ProxyService::CreateDirect()),
91 ssl_config_service_(new SSLConfigServiceDefaults), 89 ssl_config_service_(new SSLConfigServiceDefaults),
92 http_auth_handler_factory_( 90 http_auth_handler_factory_(
93 HttpAuthHandlerFactory::CreateDefault(&host_resolver_)), 91 HttpAuthHandlerFactory::CreateDefault(&host_resolver_)),
94 http_server_properties_(new HttpServerPropertiesImpl), 92 http_server_properties_(new HttpServerPropertiesImpl),
95 session_(CreateNetworkSession()), 93 session_(CreateNetworkSession()),
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 params.host_resolver = &host_resolver_; 169 params.host_resolver = &host_resolver_;
172 params.cert_verifier = cert_verifier_.get(); 170 params.cert_verifier = cert_verifier_.get();
173 params.transport_security_state = transport_security_state_.get(); 171 params.transport_security_state = transport_security_state_.get();
174 params.cert_transparency_verifier = &ct_verifier_; 172 params.cert_transparency_verifier = &ct_verifier_;
175 params.ct_policy_enforcer = &ct_policy_enforcer_; 173 params.ct_policy_enforcer = &ct_policy_enforcer_;
176 params.proxy_service = proxy_service_.get(); 174 params.proxy_service = proxy_service_.get();
177 params.client_socket_factory = &socket_factory_; 175 params.client_socket_factory = &socket_factory_;
178 params.ssl_config_service = ssl_config_service_.get(); 176 params.ssl_config_service = ssl_config_service_.get();
179 params.http_auth_handler_factory = http_auth_handler_factory_.get(); 177 params.http_auth_handler_factory = http_auth_handler_factory_.get();
180 params.http_server_properties = http_server_properties_.get(); 178 params.http_server_properties = http_server_properties_.get();
181 params.spdy_default_protocol = kProtoHTTP2;
182 return new HttpNetworkSession(params); 179 return new HttpNetworkSession(params);
183 } 180 }
184 181
185 void TestIPPoolingDisabled(SSLSocketDataProvider* ssl); 182 void TestIPPoolingDisabled(SSLSocketDataProvider* ssl);
186 183
187 MockClientSocketFactory socket_factory_; 184 MockClientSocketFactory socket_factory_;
188 MockCachingHostResolver host_resolver_; 185 MockCachingHostResolver host_resolver_;
189 std::unique_ptr<CertVerifier> cert_verifier_; 186 std::unique_ptr<CertVerifier> cert_verifier_;
190 std::unique_ptr<TransportSecurityState> transport_security_state_; 187 std::unique_ptr<TransportSecurityState> transport_security_state_;
191 MultiLogCTVerifier ct_verifier_; 188 MultiLogCTVerifier ct_verifier_;
(...skipping 748 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 ssl.channel_id_sent = true; 937 ssl.channel_id_sent = true;
941 ssl.SetNextProto(kProtoHTTP2); 938 ssl.SetNextProto(kProtoHTTP2);
942 TestIPPoolingDisabled(&ssl); 939 TestIPPoolingDisabled(&ssl);
943 } 940 }
944 941
945 // It would be nice to also test the timeouts in SSLClientSocketPool. 942 // It would be nice to also test the timeouts in SSLClientSocketPool.
946 943
947 } // namespace 944 } // namespace
948 945
949 } // namespace net 946 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_http_stream.cc ('k') | net/spdy/bidirectional_stream_spdy_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698