Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2141043002: Revert of [gin] Unify snapshot loading on Windows and other platforms. (Closed)

Created:
4 years, 5 months ago by oth
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [gin] Unify snapshot loading on Windows and other platforms. (patchset #2 id:20001 of https://codereview.chromium.org/2103903002/ ) Reason for revert: Investigate effect on Win7 startup.cold.blank_page metrics. BUG=501799, 625516 Original issue's description: > [gin] Unify snapshot loading on Windows and other platforms. > > Removes extra v8 snapshot and natives validation on Windows. All platforms > have the same validation henceforth. > > BUG=501799 > > Committed: https://crrev.com/10b5a96b363a6ff23176d27a2e7fb1bba300f089 > Cr-Commit-Position: refs/heads/master@{#403430} TBR=jochen@chromium.org,ben@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=501799 Committed: https://crrev.com/2a653192101213ec193c87e63ee119ab0dda3dd4 Cr-Commit-Position: refs/heads/master@{#405111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -11 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gin/BUILD.gn View 1 chunk +35 lines, -0 lines 0 comments Download
A gin/fingerprint/fingerprint_v8_snapshot.gypi View 1 chunk +47 lines, -0 lines 0 comments Download
A gin/fingerprint/fingerprint_v8_snapshot.py View 1 chunk +86 lines, -0 lines 0 comments Download
M gin/gin.gyp View 1 chunk +24 lines, -0 lines 0 comments Download
M gin/v8_initializer.cc View 6 chunks +63 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
oth
Created Revert of [gin] Unify snapshot loading on Windows and other platforms.
4 years, 5 months ago (2016-07-12 13:12:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141043002/1
4 years, 5 months ago (2016-07-12 13:12:51 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-12 13:12:53 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-12 15:36:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141043002/1
4 years, 5 months ago (2016-07-13 09:03:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 10:06:31 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 10:08:03 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a653192101213ec193c87e63ee119ab0dda3dd4
Cr-Commit-Position: refs/heads/master@{#405111}

Powered by Google App Engine
This is Rietveld 408576698