Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: gin/gin.gyp

Issue 2141043002: Revert of [gin] Unify snapshot loading on Windows and other platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/fingerprint/fingerprint_v8_snapshot.py ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/gin.gyp
diff --git a/gin/gin.gyp b/gin/gin.gyp
index aeecb22efbf3eb999869d266d8d46848f4a68118..0ea039fe72f8ba63353d34425f1f68d3f30e5ee5 100644
--- a/gin/gin.gyp
+++ b/gin/gin.gyp
@@ -84,6 +84,30 @@
'wrappable.h',
'wrapper_info.cc',
],
+ 'conditions': [
+ ['v8_use_external_startup_data==1 and OS=="win"', {
+ 'dependencies': [
+ 'gin_v8_snapshot_fingerprint',
+ '../crypto/crypto.gyp:crypto',
+ ],
+ 'sources': [
+ '<(gin_gen_path)/v8_snapshot_fingerprint.cc',
+ ],
+ 'defines': [
+ 'V8_VERIFY_EXTERNAL_STARTUP_DATA',
+ ]
+ }],
+ ],
+ },
+ {
+ 'target_name': 'gin_v8_snapshot_fingerprint',
+ 'type': 'none',
+ 'variables': {
+ 'snapshot_file': '<(PRODUCT_DIR)/snapshot_blob.bin',
+ 'natives_file': '<(PRODUCT_DIR)/natives_blob.bin',
+ 'output_file': '<(gin_gen_path)/v8_snapshot_fingerprint.cc',
+ },
+ 'includes': [ '../gin/fingerprint/fingerprint_v8_snapshot.gypi' ],
},
{
'target_name': 'gin_shell',
« no previous file with comments | « gin/fingerprint/fingerprint_v8_snapshot.py ('k') | gin/v8_initializer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698