Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2140733003: [Editing][CodeHealth] Make Node::rootEditableElement static (Closed)

Created:
4 years, 5 months ago by yoichio
Modified:
4 years, 5 months ago
Reviewers:
tkent, yosin_UTC9
CC:
aboxhall, aboxhall+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, eae+blinkwatch, groby+blinkspell_chromium.org, haraken, jchaffraix+rendering, je_julie, leviw+renderwatch, nektarios, nektar+watch_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][CodeHealth] Make Node::rootEditableElement static Make Node::isRootEditableElement(), rootEditableElement(), and rootEditableElement(EditableType) static. This is preparation to move all Node::*editable* functions to core/editing/ TEST=No change in behavior Committed: https://crrev.com/24ea6629ef3f75e2dc01d438729d18918a80f80b Cr-Commit-Position: refs/heads/master@{#405034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -59 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 10 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
yoichio
4 years, 5 months ago (2016-07-12 04:15:50 UTC) #3
yosin_UTC9
lgtm
4 years, 5 months ago (2016-07-12 04:17:10 UTC) #4
tkent
lgtm
4 years, 5 months ago (2016-07-12 08:01:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140733003/1
4 years, 5 months ago (2016-07-12 08:12:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191165)
4 years, 5 months ago (2016-07-12 12:15:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140733003/1
4 years, 5 months ago (2016-07-13 01:39:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 05:03:19 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 05:03:26 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 05:06:06 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24ea6629ef3f75e2dc01d438729d18918a80f80b
Cr-Commit-Position: refs/heads/master@{#405034}

Powered by Google App Engine
This is Rietveld 408576698