third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp - Issue 2140733003: [Editing][CodeHealth] Make Node::rootEditableElement static

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

Issue 2140733003: [Editing][CodeHealth] Make Node::rootEditableElement static (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

index 0efee04706fdaf33e9648b777816017dd47feb93..0bf84818a29f1e8664e767cf0fb1a97ca0e5b6e3 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

@@ -47,7 +47,7 @@ SpellCheckRequest::SpellCheckRequest(

: m_requester(nullptr)

, m_checkingRange(checkingRange)

, m_paragraphRange(paragraphRange)

- , m_rootEditableElement(m_checkingRange->startContainer()->rootEditableElement())

+ , m_rootEditableElement(blink::rootEditableElement(*m_checkingRange->startContainer()))

, m_requestData(unrequestedTextCheckingSequence, text, mask, processType, documentMarkersInRange, documentMarkerOffsets)

, m_requestNumber(requestNumber)

{

@@ -84,7 +84,7 @@ SpellCheckRequest* SpellCheckRequest::create(TextCheckingTypeMask textCheckingOp

{

if (checkingRange.isNull())

return nullptr;

- if (!checkingRange.startPosition().computeContainerNode()->rootEditableElement())

+ if (!blink::rootEditableElement(*checkingRange.startPosition().computeContainerNode()))

return nullptr;

String text = plainText(checkingRange, TextIteratorEmitsObjectReplacementCharacter);