Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2140733003: [Editing][CodeHealth] Make Node::rootEditableElement static (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/dom/Node.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index 67e29c95e205616ad139015f196de9e2d76be911..0062ab37ad6142bec2e87584c301b5fc5b704988 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -2425,7 +2425,7 @@ void Element::updateFocusAppearance(SelectionBehaviorOnFocus selectionBehavior)
{
if (selectionBehavior == SelectionBehaviorOnFocus::None)
return;
- if (isRootEditableElement()) {
+ if (isRootEditableElement(*this)) {
LocalFrame* frame = document().frame();
if (!frame)
return;
@@ -2465,7 +2465,7 @@ bool Element::supportsFocus() const
// it won't be focusable. Furthermore, supportsFocus cannot just return true
// always or else tabIndex() will change for all HTML elements.
return hasElementFlag(TabIndexWasSetExplicitly)
- || isRootEditableElement()
+ || isRootEditableElement(*this)
|| (isShadowHost(this) && authorShadowRoot() && authorShadowRoot()->delegatesFocus())
|| supportsSpatialNavigationFocus();
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/dom/Node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698