[heap] Untangle Marking and friends from heap dependencies.

[heap] Untangle Marking and friends from heap dependencies.

BUG=

Committed: https://crrev.com/ea90556a2f566d207b2a2e63b29f103e36c2c12f
Cr-Commit-Position: refs/heads/master@{#37685}

[Hannes Payer (out of office), 2016-07-12 13:51:21]

hpayer@chromium.org changed reviewers:
+ mlippautz@chromium.org, ulan@chromium.org

[Hannes Payer (out of office), 2016-07-12 13:51:22]

PTAL. There are many ways how this code can be structured... comments welcome :)

[Hannes Payer (out of office), 2016-07-12 14:02:32]

https://codereview.chromium.org/2139133003/diff/40001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/2139133003/diff/40001/src/heap/mark-compact.h...
src/heap/mark-compact.h:32: class ObjectMarking : public AllStatic {
Instead of creating this class, we could add the methods to
MarkCompactCollector.

[Michael Lippautz, 2016-07-12 14:22:32]

LGTM

https://codereview.chromium.org/2139133003/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2139133003/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:41: // produce
nit: formatting off

https://codereview.chromium.org/2139133003/diff/40001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/2139133003/diff/40001/src/heap/mark-compact.h...
src/heap/mark-compact.h:32: class ObjectMarking : public AllStatic {
On 2016/07/12 14:02:32, Hannes Payer wrote:
> Instead of creating this class, we could add the methods to
> MarkCompactCollector.

Acknowledged.

https://codereview.chromium.org/2139133003/diff/40001/test/unittests/heap/mar...
File test/unittests/heap/marking-unittest.cc (right):

https://codereview.chromium.org/2139133003/diff/40001/test/unittests/heap/mar...
test/unittests/heap/marking-unittest.cc:29: }
free(bitmap) or you will get mail from leak sanitizer ;)

(+ all following tests)

[ulan, 2016-07-12 14:24:53]

lgtm!

[Hannes Payer (out of office), 2016-07-12 14:44:26]

https://codereview.chromium.org/2139133003/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2139133003/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:41: // produce
On 2016/07/12 14:22:31, Michael Lippautz wrote:
> nit: formatting off

Done.

https://codereview.chromium.org/2139133003/diff/40001/test/unittests/heap/mar...
File test/unittests/heap/marking-unittest.cc (right):

https://codereview.chromium.org/2139133003/diff/40001/test/unittests/heap/mar...
test/unittests/heap/marking-unittest.cc:29: }
On 2016/07/12 14:22:31, Michael Lippautz wrote:
> free(bitmap) or you will get mail from leak sanitizer ;)
> 
> (+ all following tests)

Done.

[Hannes Payer (out of office), 2016-07-12 14:45:05]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-07-12 14:45:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2139133003/#ps80001
(title: "fix comment formatting")

[commit-bot: I haz the power, 2016-07-12 14:45:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 15:09:03]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-12 15:10:58]

Description was changed from

==========
[heap] Untangle Marking and friends from heap dependencies.

BUG=
==========

to

==========
[heap] Untangle Marking and friends from heap dependencies.

BUG=

Committed: https://crrev.com/ea90556a2f566d207b2a2e63b29f103e36c2c12f
Cr-Commit-Position: refs/heads/master@{#37685}
==========

[commit-bot: I haz the power, 2016-07-12 15:10:59]

Patchset 5 (id:??) landed as
https://crrev.com/ea90556a2f566d207b2a2e63b29f103e36c2c12f
Cr-Commit-Position: refs/heads/master@{#37685}