Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: test/cctest/heap/test-heap.cc

Issue 2139133003: [heap] Untangle Marking and friends from heap dependencies. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix comment formatting Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/v8.gyp ('k') | test/cctest/test-unboxed-doubles.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index 5d5515bad8266d96f72b211002bd6b2fd4b1bec9..7dab3ffc42b6f2e22d814aa3e075bcbf034fe7a2 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -720,7 +720,7 @@ TEST(DoNotPromoteWhiteObjectsOnScavenge) {
HandleScope scope(isolate);
Handle<Object> white = factory->NewStringFromStaticChars("white");
- CHECK(Marking::IsWhite(Marking::MarkBitFrom(HeapObject::cast(*white))));
+ CHECK(Marking::IsWhite(ObjectMarking::MarkBitFrom(HeapObject::cast(*white))));
heap->CollectGarbage(NEW_SPACE);
@@ -739,7 +739,8 @@ TEST(PromoteGreyOrBlackObjectsOnScavenge) {
IncrementalMarking* marking = heap->incremental_marking();
marking->Stop();
heap->StartIncrementalMarking();
- while (Marking::IsWhite(Marking::MarkBitFrom(HeapObject::cast(*marked)))) {
+ while (
+ Marking::IsWhite(ObjectMarking::MarkBitFrom(HeapObject::cast(*marked)))) {
marking->Step(MB, IncrementalMarking::NO_GC_VIA_STACK_GUARD,
IncrementalMarking::FORCE_MARKING,
IncrementalMarking::DO_NOT_FORCE_COMPLETION);
@@ -2632,7 +2633,7 @@ TEST(InstanceOfStubWriteBarrier) {
CHECK(f->IsOptimized());
- while (!Marking::IsBlack(Marking::MarkBitFrom(f->code())) &&
+ while (!Marking::IsBlack(ObjectMarking::MarkBitFrom(f->code())) &&
!marking->IsStopped()) {
// Discard any pending GC requests otherwise we will get GC when we enter
// code below.
@@ -5765,7 +5766,7 @@ TEST(Regress3631) {
v8::Utils::OpenHandle(*v8::Local<v8::Object>::Cast(result));
Handle<JSWeakCollection> weak_map(reinterpret_cast<JSWeakCollection*>(*obj));
while (!Marking::IsBlack(
- Marking::MarkBitFrom(HeapObject::cast(weak_map->table()))) &&
+ ObjectMarking::MarkBitFrom(HeapObject::cast(weak_map->table()))) &&
!marking->IsStopped()) {
marking->Step(MB, IncrementalMarking::NO_GC_VIA_STACK_GUARD);
}
@@ -6680,10 +6681,10 @@ TEST(Regress598319) {
}
CHECK(heap->lo_space()->Contains(arr.get()));
- CHECK(Marking::IsWhite(Marking::MarkBitFrom(arr.get())));
+ CHECK(Marking::IsWhite(ObjectMarking::MarkBitFrom(arr.get())));
for (int i = 0; i < arr.get()->length(); i++) {
CHECK(Marking::IsWhite(
- Marking::MarkBitFrom(HeapObject::cast(arr.get()->get(i)))));
+ ObjectMarking::MarkBitFrom(HeapObject::cast(arr.get()->get(i)))));
}
// Start incremental marking.
@@ -6697,7 +6698,7 @@ TEST(Regress598319) {
// Check that we have not marked the interesting array during root scanning.
for (int i = 0; i < arr.get()->length(); i++) {
CHECK(Marking::IsWhite(
- Marking::MarkBitFrom(HeapObject::cast(arr.get()->get(i)))));
+ ObjectMarking::MarkBitFrom(HeapObject::cast(arr.get()->get(i)))));
}
// Now we search for a state where we are in incremental marking and have
@@ -6731,7 +6732,7 @@ TEST(Regress598319) {
// progress bar, we would fail here.
for (int i = 0; i < arr.get()->length(); i++) {
CHECK(Marking::IsBlack(
- Marking::MarkBitFrom(HeapObject::cast(arr.get()->get(i)))));
+ ObjectMarking::MarkBitFrom(HeapObject::cast(arr.get()->get(i)))));
}
}
« no previous file with comments | « src/v8.gyp ('k') | test/cctest/test-unboxed-doubles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698