Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2138823002: Clamp in VisualViewport::setScrollPosition. (Closed)

Created:
4 years, 5 months ago by Eric Seckler
Modified:
4 years, 5 months ago
Reviewers:
bokan, skobes
CC:
chromium-reviews, blink-reviews, Sami, skobes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamp in VisualViewport::setScrollPosition. This avoids situations where the viewport's scroll animator may be updated with non-clamped positions by ScrollableArea::setScrollPosition and RootFrameViewport's scrolling may behave incorrectly. BUG=626315 Committed: https://crrev.com/3f022f5dd7dba6eb56ea8f27ff8636fd33bb0543 Cr-Commit-Position: refs/heads/master@{#404799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/VisualViewport.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Eric Seckler
CQ dry-run in progress, let's see if it breaks anything.
4 years, 5 months ago (2016-07-11 16:36:28 UTC) #4
bokan
lgtm
4 years, 5 months ago (2016-07-11 16:51:02 UTC) #5
skobes
lgtm
4 years, 5 months ago (2016-07-11 16:52:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138823002/1
4 years, 5 months ago (2016-07-12 06:59:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 08:07:34 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 08:08:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f022f5dd7dba6eb56ea8f27ff8636fd33bb0543
Cr-Commit-Position: refs/heads/master@{#404799}

Powered by Google App Engine
This is Rietveld 408576698