Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: third_party/WebKit/Source/core/frame/VisualViewport.h

Issue 2138823002: Clamp in VisualViewport::setScrollPosition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/VisualViewport.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 FloatPoint viewportToRootFrame(const FloatPoint&) const; 166 FloatPoint viewportToRootFrame(const FloatPoint&) const;
167 FloatPoint rootFrameToViewport(const FloatPoint&) const; 167 FloatPoint rootFrameToViewport(const FloatPoint&) const;
168 IntPoint viewportToRootFrame(const IntPoint&) const; 168 IntPoint viewportToRootFrame(const IntPoint&) const;
169 IntPoint rootFrameToViewport(const IntPoint&) const; 169 IntPoint rootFrameToViewport(const IntPoint&) const;
170 170
171 // ScrollableArea implementation 171 // ScrollableArea implementation
172 HostWindow* getHostWindow() const override; 172 HostWindow* getHostWindow() const override;
173 DoubleRect visibleContentRectDouble(IncludeScrollbarsInRect = ExcludeScrollb ars) const override; 173 DoubleRect visibleContentRectDouble(IncludeScrollbarsInRect = ExcludeScrollb ars) const override;
174 IntRect visibleContentRect(IncludeScrollbarsInRect = ExcludeScrollbars) cons t override; 174 IntRect visibleContentRect(IncludeScrollbarsInRect = ExcludeScrollbars) cons t override;
175 bool shouldUseIntegerScrollOffset() const override; 175 bool shouldUseIntegerScrollOffset() const override;
176 void setScrollPosition(const DoublePoint&, ScrollType, ScrollBehavior = Scro llBehaviorInstant) override;
176 LayoutRect visualRectForScrollbarParts() const override { ASSERT_NOT_REACHED (); return LayoutRect(); } 177 LayoutRect visualRectForScrollbarParts() const override { ASSERT_NOT_REACHED (); return LayoutRect(); }
177 bool isActive() const override { return false; } 178 bool isActive() const override { return false; }
178 int scrollSize(ScrollbarOrientation) const override; 179 int scrollSize(ScrollbarOrientation) const override;
179 bool isScrollCornerVisible() const override { return false; } 180 bool isScrollCornerVisible() const override { return false; }
180 IntRect scrollCornerRect() const override { return IntRect(); } 181 IntRect scrollCornerRect() const override { return IntRect(); }
181 IntPoint scrollPosition() const override { return flooredIntPoint(m_offset); } 182 IntPoint scrollPosition() const override { return flooredIntPoint(m_offset); }
182 DoublePoint scrollPositionDouble() const override { return m_offset; } 183 DoublePoint scrollPositionDouble() const override { return m_offset; }
183 IntPoint minimumScrollPosition() const override; 184 IntPoint minimumScrollPosition() const override;
184 IntPoint maximumScrollPosition() const override; 185 IntPoint maximumScrollPosition() const override;
185 DoublePoint maximumScrollPositionDouble() const override; 186 DoublePoint maximumScrollPositionDouble() const override;
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 float m_scale; 260 float m_scale;
260 IntSize m_size; 261 IntSize m_size;
261 float m_topControlsAdjustment; 262 float m_topControlsAdjustment;
262 float m_maxPageScale; 263 float m_maxPageScale;
263 bool m_trackPinchZoomStatsForPage; 264 bool m_trackPinchZoomStatsForPage;
264 }; 265 };
265 266
266 } // namespace blink 267 } // namespace blink
267 268
268 #endif // VisualViewport_h 269 #endif // VisualViewport_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/VisualViewport.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698