IDL: Remove duplicated typedefs

IDL: Remove duplicated typedefs

Typedefs have per-component visibility so we don't need to have
duplicated definitions.

BUG=627286
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/98f23eaf84da1882a8dbf5e3c784f32242c2951a
Cr-Commit-Position: refs/heads/master@{#405429}

[bashi, 2016-07-11 07:43:57]

Description was changed from

==========
IDL: Remove duplicated typedefs

Typedefs have per-component visibility so we don't need to have
duplicated definitions.
==========

to

==========
IDL: Remove duplicated typedefs

Typedefs have per-component visibility so we don't need to have
duplicated definitions.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[bashi, 2016-07-11 07:46:01]

bashi@chromium.org changed reviewers:
+ johnme@chromium.org, kbr@chromium.org

[bashi, 2016-07-11 07:46:02]

PTAL

[haraken, 2016-07-11 07:58:18]

LGTM on my side

[johnme, 2016-07-11 11:00:46]

lgtm with comment

https://codereview.chromium.org/2138673002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl
(left):

https://codereview.chromium.org/2138673002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl:7: typedef
object JSON;
It's rather awkward for modules/push_messaging/PushMessageData.idl to depend on
modules/fetch/Body.idl, since they're unrelated specifications. Instead,
consider moving the JSON typedef to 
core/dom/CommonDefinitions.idl

[Ken Russell (switch to Gerrit), 2016-07-11 20:08:39]

LGTM but please reference a bug ID in the description for more background.

https://codereview.chromium.org/2138673002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/OESTextureHalfFloat.idl (right):

https://codereview.chromium.org/2138673002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/OESTextureHalfFloat.idl:30: ] interface
OESTextureHalfFloat {
Where is the implicit reference from OESTextureHalfFloat to
WebGLRenderingContextBase? The CL description mentions that these typedefs have
per-component visibility -- what is a component in this context?

[bashi, 2016-07-11 23:18:47]

Description was changed from

==========
IDL: Remove duplicated typedefs

Typedefs have per-component visibility so we don't need to have
duplicated definitions.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
IDL: Remove duplicated typedefs

Typedefs have per-component visibility so we don't need to have
duplicated definitions.

BUG=627286

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[bashi, 2016-07-11 23:19:18]

Thanks for review! Added bug number.

https://codereview.chromium.org/2138673002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl
(left):

https://codereview.chromium.org/2138673002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl:7: typedef
object JSON;
On 2016/07/11 11:00:46, johnme wrote:
> It's rather awkward for modules/push_messaging/PushMessageData.idl to depend
on
> modules/fetch/Body.idl, since they're unrelated specifications. Instead,
> consider moving the JSON typedef to 
> core/dom/CommonDefinitions.idl

Done.

https://codereview.chromium.org/2138673002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/OESTextureHalfFloat.idl (right):

https://codereview.chromium.org/2138673002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/OESTextureHalfFloat.idl:30: ] interface
OESTextureHalfFloat {
On 2016/07/11 20:08:39, Ken Russell wrote:
> Where is the implicit reference from OESTextureHalfFloat to
> WebGLRenderingContextBase? The CL description mentions that these typedefs
have
> per-component visibility -- what is a component in this context?

Sorry not being clear. "per-component" seems misreading. In terms of blink's IDL
there are two components: core/ and modules/. And typedefs in core/ are visible
from modules/.

[bashi, 2016-07-11 23:19:58]

bashi@chromium.org changed reviewers:
+ yhirano@chromium.org

[bashi, 2016-07-11 23:19:59]

yhirano@: could you review modules/fetch ?

[yhirano, 2016-07-12 03:38:26]

lgtm

[bashi, 2016-07-12 04:04:15]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-07-12 04:04:16]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org,
kbr@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2138673002/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2016-07-12 04:05:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 05:34:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 05:34:02]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bashi, 2016-07-12 05:52:19]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-07-12 05:53:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 06:42:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 06:42:44]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[bashi, 2016-07-12 06:44:57]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-07-12 06:45:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 07:17:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 07:17:42]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[bashi, 2016-07-12 07:18:57]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-07-12 07:19:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 08:16:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 08:16:14]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Ken Russell (switch to Gerrit), 2016-07-13 22:51:16]

On 2016/07/12 08:16:14, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

Sorry for this trouble. I've filed http://crbug.com/628022 about these
mysterious failures of an entire shard of the WebGL conformance tests. Let's
re-try.

[Ken Russell (switch to Gerrit), 2016-07-13 22:51:24]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-07-13 22:52:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 02:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 02:17:19]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[bashi, 2016-07-14 03:05:45]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-07-14 03:05:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 03:53:05]

Description was changed from

==========
IDL: Remove duplicated typedefs

Typedefs have per-component visibility so we don't need to have
duplicated definitions.

BUG=627286

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
IDL: Remove duplicated typedefs

Typedefs have per-component visibility so we don't need to have
duplicated definitions.

BUG=627286

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-07-14 03:53:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 03:53:15]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 03:55:14]

Description was changed from

==========
IDL: Remove duplicated typedefs

Typedefs have per-component visibility so we don't need to have
duplicated definitions.

BUG=627286

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
IDL: Remove duplicated typedefs

Typedefs have per-component visibility so we don't need to have
duplicated definitions.

BUG=627286

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/98f23eaf84da1882a8dbf5e3c784f32242c2951a
Cr-Commit-Position: refs/heads/master@{#405429}
==========

[commit-bot: I haz the power, 2016-07-14 03:55:16]

Patchset 2 (id:??) landed as
https://crrev.com/98f23eaf84da1882a8dbf5e3c784f32242c2951a
Cr-Commit-Position: refs/heads/master@{#405429}