third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl - Issue 2138673002: IDL: Remove duplicated typedefs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl

Issue 2138673002: IDL: Remove duplicated typedefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // http://w3c.github.io/push-api/#pushmessagedata-interface	5 // http://w3c.github.io/push-api/#pushmessagedata-interface

6	6

7 typedef object JSON;
johnme 2016/07/11 11:00:46 It's rather awkward for modules/push_messaging/Pus It's rather awkward for modules/push_messaging/PushMessageData.idl to depend on modules/fetch/Body.idl, since they're unrelated specifications. Instead, consider moving the JSON typedef to core/dom/CommonDefinitions.idl bashi 2016/07/11 23:19:18 Done. Show quoted text On 2016/07/11 11:00:46, johnme wrote: > It's rather awkward for modules/push_messaging/PushMessageData.idl to depend on > modules/fetch/Body.idl, since they're unrelated specifications. Instead, > consider moving the JSON typedef to > core/dom/CommonDefinitions.idl Done.
8

9 [	7 [

10 Exposed=ServiceWorker,	8 Exposed=ServiceWorker,

11 ] interface PushMessageData {	9 ] interface PushMessageData {

12 ArrayBuffer arrayBuffer();	10 ArrayBuffer arrayBuffer();

13 Blob blob();	11 Blob blob();

14 [CallWith=ScriptState, RaisesException] JSON json();	12 [CallWith=ScriptState, RaisesException] JSON json();

15 USVString text();	13 USVString text();

16 };	14 };

OLD	NEW