Merge two update type fields in RenderLayerCompositor

Merge two update type fields in RenderLayerCompositor

This CL merges the two update type fields in RenderLayer compositor. They were
both doing the same thing. In the future, we want to set more of the
RenderLayerCompositor dirty bits from the new m_updateType field, but this is a
start.

Also, remove the mutable keyword from a field where it wasn't needed.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170509

[esprehn, 2014-04-01 00:13:15]

lgtm. lets add another ASSERT though.

https://codereview.chromium.org/213833014/diff/1/Source/core/rendering/compos...
File Source/core/rendering/compositing/RenderLayerCompositor.cpp (right):

https://codereview.chromium.org/213833014/diff/1/Source/core/rendering/compos...
Source/core/rendering/compositing/RenderLayerCompositor.cpp:366:
ASSERT_NOT_REACHED();
Lets put this also at the top of the function as ASSERT(updateType !=
CompositingUpdateNone); otherwise you can enter here with that value and as long
as you keep hitting one of those early returns things will work.

[abarth-chromium, 2014-04-01 00:30:45]

The CQ bit was checked by abarth@chromium.org

[abarth-chromium, 2014-04-01 00:30:46]

The CQ bit was unchecked by abarth@chromium.org

[abarth-chromium, 2014-04-01 00:30:59]

On 2014/04/01 00:13:15, esprehn wrote:
> lgtm. lets add another ASSERT though.
> 
>
https://codereview.chromium.org/213833014/diff/1/Source/core/rendering/compos...
> File Source/core/rendering/compositing/RenderLayerCompositor.cpp (right):
> 
>
https://codereview.chromium.org/213833014/diff/1/Source/core/rendering/compos...
> Source/core/rendering/compositing/RenderLayerCompositor.cpp:366:
> ASSERT_NOT_REACHED();
> Lets put this also at the top of the function as ASSERT(updateType !=
> CompositingUpdateNone); otherwise you can enter here with that value and as
long
> as you keep hitting one of those early returns things will work.

Good idea.

[abarth-chromium, 2014-04-01 00:50:12]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-04-01 00:50:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/213833014/20001

[commit-bot: I haz the power, 2014-04-01 01:18:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 01:18:09]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[abarth-chromium, 2014-04-01 01:55:30]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-04-01 01:55:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/213833014/20001

[commit-bot: I haz the power, 2014-04-01 03:57:35]

Change committed as 170509