Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: Source/core/rendering/compositing/RenderLayerCompositor.h

Issue 213833014: Merge two update type fields in RenderLayerCompositor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Moar asserts Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 28 matching lines...) Expand all
39 class FixedPositionViewportConstraints; 39 class FixedPositionViewportConstraints;
40 class GraphicsLayer; 40 class GraphicsLayer;
41 class RenderEmbeddedObject; 41 class RenderEmbeddedObject;
42 class RenderLayerStackingNode; 42 class RenderLayerStackingNode;
43 class RenderPart; 43 class RenderPart;
44 class RenderVideo; 44 class RenderVideo;
45 class ScrollingCoordinator; 45 class ScrollingCoordinator;
46 class StickyPositionViewportConstraints; 46 class StickyPositionViewportConstraints;
47 47
48 enum CompositingUpdateType { 48 enum CompositingUpdateType {
49 CompositingUpdateNone,
49 CompositingUpdateAfterStyleChange, 50 CompositingUpdateAfterStyleChange,
50 CompositingUpdateAfterLayout, 51 CompositingUpdateAfterLayout,
51 CompositingUpdateOnScroll, 52 CompositingUpdateOnScroll,
52 CompositingUpdateOnCompositedScroll, 53 CompositingUpdateOnCompositedScroll,
53 CompositingUpdateAfterCanvasContextChange 54 CompositingUpdateAfterCanvasContextChange
54 }; 55 };
55 56
56 // RenderLayerCompositor manages the hierarchy of 57 // RenderLayerCompositor manages the hierarchy of
57 // composited RenderLayers. It determines which RenderLayers 58 // composited RenderLayers. It determines which RenderLayers
58 // become compositing, and creates and maintains a hierarchy of 59 // become compositing, and creates and maintains a hierarchy of
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 315
315 private: 316 private:
316 DocumentLifecycle& lifecycle() const; 317 DocumentLifecycle& lifecycle() const;
317 318
318 RenderView& m_renderView; 319 RenderView& m_renderView;
319 OwnPtr<GraphicsLayer> m_rootContentLayer; 320 OwnPtr<GraphicsLayer> m_rootContentLayer;
320 OwnPtr<GraphicsLayer> m_rootTransformLayer; 321 OwnPtr<GraphicsLayer> m_rootTransformLayer;
321 322
322 CompositingReasonFinder m_compositingReasonFinder; 323 CompositingReasonFinder m_compositingReasonFinder;
323 324
325 CompositingUpdateType m_pendingUpdateType;
326
324 bool m_hasAcceleratedCompositing; 327 bool m_hasAcceleratedCompositing;
325 bool m_showRepaintCounter; 328 bool m_showRepaintCounter;
326 329
327 // FIXME: This should absolutely not be mutable. 330 bool m_needsToRecomputeCompositingRequirements;
328 mutable bool m_needsToRecomputeCompositingRequirements;
329 bool m_needsToUpdateLayerTreeGeometry; 331 bool m_needsToUpdateLayerTreeGeometry;
330 332
331 // FIXME: We should remove m_pendingUpdateType and propagate the bits with C ompositingPropertyUpdater instead.
332 GraphicsLayerUpdater::UpdateType m_pendingUpdateType;
333 CompositingPropertyUpdater::UpdateType m_pendingPropertyUpdateType;
334
335 bool m_compositing; 333 bool m_compositing;
336 bool m_compositingLayersNeedRebuild; 334 bool m_compositingLayersNeedRebuild;
337 bool m_forceCompositingMode; 335 bool m_forceCompositingMode;
338 bool m_needsUpdateCompositingRequirementsState; 336 bool m_needsUpdateCompositingRequirementsState;
339 337
340 bool m_isTrackingRepaints; // Used for testing. 338 bool m_isTrackingRepaints; // Used for testing.
341 339
342 RootLayerAttachment m_rootLayerAttachment; 340 RootLayerAttachment m_rootLayerAttachment;
343 341
344 // Enclosing container layer, which clips for iframe content 342 // Enclosing container layer, which clips for iframe content
(...skipping 16 matching lines...) Expand all
361 OwnPtr<GraphicsLayer> m_layerForScrollCorner; 359 OwnPtr<GraphicsLayer> m_layerForScrollCorner;
362 #if USE(RUBBER_BANDING) 360 #if USE(RUBBER_BANDING)
363 OwnPtr<GraphicsLayer> m_layerForOverhangShadow; 361 OwnPtr<GraphicsLayer> m_layerForOverhangShadow;
364 #endif 362 #endif
365 }; 363 };
366 364
367 365
368 } // namespace WebCore 366 } // namespace WebCore
369 367
370 #endif // RenderLayerCompositor_h 368 #endif // RenderLayerCompositor_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698