Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2138203002:
[Signin] Add Signin_Impression_FromPasswordBubble user action for Desktops (Closed)
|
Created:
4 years, 5 months ago by gogerald1 Modified:
4 years, 5 months ago CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd Signin_Impression_FromPasswordBubble user action for Desktops
BUG=615825
Committed: https://crrev.com/c4c5b6f47e8656ddbbfb156aa09ec7ebe361adef
Cr-Commit-Position: refs/heads/master@{#404907}
Patch Set 1 : add user actions #
Messages
Total messages: 35 (20 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== add user actions BUG= ========== to ========== [Signin] Add Signin_Impression_FromPasswordBubble user action BUG=615825 ==========
Description was changed from ========== [Signin] Add Signin_Impression_FromPasswordBubble user action BUG=615825 ========== to ========== Add Signin_Impression_FromPasswordBubble user action for Desktops BUG=615825 ==========
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gogerald@chromium.org changed reviewers: + asvitkine@chromium.org, sky@chromium.org
asvitkine@chromium.org: Please review changes in tools/metrics/actions/actions.xml sky@chromium.org: Please review changes in chrome/browser/ui/*
gogerald@chromium.org changed reviewers: + msw@chromium.org - sky@chromium.org
hi, msw@ please help review changes in chrome/browser/ui/*
lgtm
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add Signin_Impression_FromPasswordBubble user action for Desktops BUG=615825 ========== to ========== Add Signin_Impression_FromPasswordBubble user action for Desktops BUG=615825 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add Signin_Impression_FromPasswordBubble user action for Desktops BUG=615825 ========== to ========== Add Signin_Impression_FromPasswordBubble user action for Desktops BUG=615825 Committed: https://crrev.com/c4c5b6f47e8656ddbbfb156aa09ec7ebe361adef Cr-Commit-Position: refs/heads/master@{#404907} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c4c5b6f47e8656ddbbfb156aa09ec7ebe361adef Cr-Commit-Position: refs/heads/master@{#404907} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
