chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc - Issue 2138203002: [Signin] Add Signin_Impression_FromPasswordBubble user action for Desktops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 2138203002: [Signin] Add Signin_Impression_FromPasswordBubble user action for Desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add user actions Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

index 10dcaab05e6cd3d179df85e44a71977cfe4ab3b8..74c26942ac5d6b8d9f3f9ff0fff23edd446f2076 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

@@ -17,6 +17,7 @@

#include "chrome/browser/ui/views/passwords/manage_password_items_view.h"

#include "chrome/browser/ui/views/passwords/manage_passwords_icon_views.h"

#include "chrome/grit/generated_resources.h"

+#include "content/public/browser/user_metrics.h"

#include "grit/components_strings.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/material_design/material_design_controller.h"

@@ -593,6 +594,8 @@ ManagePasswordsBubbleView::SignInPromoView::SignInPromoView(

layout->AddView(no_button_);

parent_->set_initially_focused_view(signin_button_);

+ content::RecordAction(

+ base::UserMetricsAction("Signin_Impression_FromPasswordBubble"));

}

void ManagePasswordsBubbleView::SignInPromoView::ButtonPressed(

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »