chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm - Issue 2138203002: [Signin] Add Signin_Impression_FromPasswordBubble user action for Desktops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm

Issue 2138203002: [Signin] Add Signin_Impression_FromPasswordBubble user action for Desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add user actions Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm b/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm

index 769992bbf832c5ef9f2958165f9222ef67b65d66..83ceb3cdf044df3bd86b0bf47323e44595bfec64 100644

--- a/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/signin_promo_view_controller.mm

@@ -9,6 +9,7 @@

#import "chrome/browser/ui/cocoa/hover_close_button.h"

#include "chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h"

#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"

+#include "content/public/browser/user_metrics.h"

#include "grit/generated_resources.h"

#import "ui/base/cocoa/controls/hyperlink_text_view.h"

#include "ui/base/l10n/l10n_util_mac.h"

@@ -99,6 +100,8 @@

[_closeButton setFrameOrigin:closeButtonOrigin];

[view setFrame:NSMakeRect(0, 0, kDesiredBubbleWidth, height)];

[self setView:view];

+ content::RecordAction(

+ base::UserMetricsAction("Signin_Impression_FromPasswordBubble"));

}

- (void)onSignInClicked:(id)sender {

« no previous file with comments | « no previous file | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('j') | no next file with comments »