Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 213773003: select.add() should support optgroup adding and before index (Closed)

Created:
6 years, 9 months ago by keishi
Modified:
6 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, watchdog-blink-watchlist_google.com, dglazkov+blink, arv+blink, adamk+blink_chromium.org, Inactive
Visibility:
Public.

Description

select.add() should support optgroup adding and before index According to the spec (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-select-element) the idl for select.add is void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null); select.add should accept an optgroup as the first argument. select.add should support an index as the second argument. BUG=345345 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170259

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Total comments: 8

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -12 lines) Patch
M LayoutTests/fast/dom/incompatible-operations.html View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/incompatible-operations-expected.txt View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
A LayoutTests/fast/forms/select/select-add.html View 1 2 3 1 chunk +93 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/select/select-add-expected.txt View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.idl View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
keishi
6 years, 9 months ago (2014-03-26 23:13:11 UTC) #1
tkent
https://codereview.chromium.org/213773003/diff/1/LayoutTests/fast/forms/select/select-add.html File LayoutTests/fast/forms/select/select-add.html (right): https://codereview.chromium.org/213773003/diff/1/LayoutTests/fast/forms/select/select-add.html#newcode54 LayoutTests/fast/forms/select/select-add.html:54: } Needs more tests. - Omit the second argument ...
6 years, 9 months ago (2014-03-27 01:18:52 UTC) #2
keishi
https://codereview.chromium.org/213773003/diff/1/LayoutTests/fast/forms/select/select-add.html File LayoutTests/fast/forms/select/select-add.html (right): https://codereview.chromium.org/213773003/diff/1/LayoutTests/fast/forms/select/select-add.html#newcode54 LayoutTests/fast/forms/select/select-add.html:54: } On 2014/03/27 01:18:53, tkent wrote: > Needs more ...
6 years, 9 months ago (2014-03-27 06:06:53 UTC) #3
tkent
https://codereview.chromium.org/213773003/diff/30001/LayoutTests/fast/forms/select/select-add.html File LayoutTests/fast/forms/select/select-add.html (right): https://codereview.chromium.org/213773003/diff/30001/LayoutTests/fast/forms/select/select-add.html#newcode19 LayoutTests/fast/forms/select/select-add.html:19: select = document.createElement('select'); We usually use four space indentation. ...
6 years, 9 months ago (2014-03-27 06:13:35 UTC) #4
keishi
https://codereview.chromium.org/213773003/diff/30001/LayoutTests/fast/forms/select/select-add.html File LayoutTests/fast/forms/select/select-add.html (right): https://codereview.chromium.org/213773003/diff/30001/LayoutTests/fast/forms/select/select-add.html#newcode19 LayoutTests/fast/forms/select/select-add.html:19: select = document.createElement('select'); On 2014/03/27 06:13:35, tkent wrote: > ...
6 years, 9 months ago (2014-03-27 06:52:02 UTC) #5
tkent
lgtm
6 years, 9 months ago (2014-03-27 06:56:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/213773003/50001
6 years, 9 months ago (2014-03-27 06:56:43 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 07:26:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-27 07:26:11 UTC) #9
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 8 months ago (2014-03-27 19:02:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/213773003/50001
6 years, 8 months ago (2014-03-27 19:02:20 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 19:12:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-03-27 19:13:00 UTC) #13
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 8 months ago (2014-03-28 02:38:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/213773003/70001
6 years, 8 months ago (2014-03-28 02:38:40 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 03:46:12 UTC) #16
Message was sent while issue was closed. 
Change committed as 170259

Powered by Google App Engine
This is Rietveld 408576698