select.add() should support optgroup adding and before index

Source/core/html/HTMLOptionsCollection.cpp

 /*
  * Copyright (C) 2006, 2011, 2012 Apple Computer, Inc.
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 75 matching lines @@
     if (index < -1) {
         exceptionState.throwDOMException(IndexSizeError, "The index provided (" + String::number(index) + ") is less than -1.");
         return;
     }
 
     HTMLSelectElement& select = toHTMLSelectElement(ownerNode());
 
     if (index == -1 || unsigned(index) >= length())
         select.add(newOption, 0, exceptionState);
     else
-        select.add(newOption, toHTMLOptionElement(item(index)), exceptionState);
+        select.addBeforeOptionAtIndex(newOption, unsigned(index), exceptionState);

[tkent, 2014/03/27 06:13:35]

Do not use C-style cast.

[keishi, 2014/03/27 06:52:03]

Done.

 
     ASSERT(!exceptionState.hadException());
 }
 
 void HTMLOptionsCollection::remove(int index)
 {
     toHTMLSelectElement(ownerNode()).remove(index);
 }
 
 void HTMLOptionsCollection::remove(HTMLOptionElement* option)
@@ skipping 41 matching lines @@
     if (!value) { // undefined or null
         base.remove(index);
         return true;
     }
     base.setOption(index, value.get(), exceptionState);
     return true;
 }
 
 } //namespace