select.add() should support optgroup adding and before index

Source/core/html/HTMLSelectElement.h

 /*
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 45 matching lines @@
     virtual void resetImpl() OVERRIDE;
 
     unsigned length() const;
 
     int size() const { return m_size; }
     bool multiple() const { return m_multiple; }
 
     bool usesMenuList() const;
 
     void add(HTMLElement*, HTMLElement* beforeElement, ExceptionState&);
+    void addBeforeOptionAtIndex(HTMLElement*, unsigned beforeIndex, ExceptionState&);

[tkent, 2014/03/27 01:18:53]

Is ImplementedAs necessary?  Doesn't an overload add(HTMLElement*, int,
ExceptionState&) work?

[keishi, 2014/03/27 06:06:53]

I tried that and the compiler said it doesn't know which to call for:
select.add(newOption, 0, exceptionState);
Since it does different things (one is append, the other is prepend) I thought
better to add ImplementAs.

 
     using Node::remove;
     void remove(int index);
 
     String value() const;
     void setValue(const String&);
     String suggestedValue() const;
     void setSuggestedValue(const String&);
 
     PassRefPtr<HTMLOptionsCollection> options();
@@ skipping 131 matching lines @@
     bool m_isProcessingUserDrivenChange;
     bool m_multiple;
     bool m_activeSelectionState;
     mutable bool m_shouldRecalcListItems;
     int m_suggestedIndex;
 };
 
 } // namespace
 
 #endif