Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 213743004: Revert of Early terminate flings when scrolling impossible (Closed)

Created:
6 years, 8 months ago by tkent
Modified:
6 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, Xianzhu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Early terminate flings when scrolling impossible (https://codereview.chromium.org/136173004/) Reason for revert: Broke a layout test, fast/events/touch/gesture/pad-gesture-fling.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast%2Fevents%2Ftouch%2Fgesture%2Fpad-gesture-fling.html Original issue's description: > Early terminate flings when scrolling impossible > > Previously, flings were terminated early only if the root layer overscrolled. > Now, flings will terminate if the fling target's |scrollBy()| method returns > false, providing consistency between layer types and saving battery on > sites with scrolling sublayers. > > Also move |DidOverscrollParams| into content/ in anticipation of using it > directly in the overscroll IPC message. > > Corresponding Blink patch: > https://codereview.chromium.org/139493003/ > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260631 TBR=aelias@chromium.org,jochen@chromium.org,jdduke@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -171 lines) Patch
M cc/input/input_handler.h View 3 chunks +9 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 3 chunks +6 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 5 chunks +18 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/in_process/synchronous_input_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_input_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/fling_animator_impl_android.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/child/touch_fling_gesture_curve.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/child/touch_fling_gesture_curve_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
D content/common/input/did_overscroll_params.h View 1 chunk +0 lines, -20 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/input/input_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_event_filter.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_proxy.h View 2 chunks +3 lines, -8 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 6 chunks +17 lines, -27 lines 0 comments Download
M content/renderer/input/input_handler_proxy_client.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 7 chunks +20 lines, -51 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/web_gesture_curve_mock.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gfx/android/scroller.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/android/scroller_unittest.cc View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Early terminate flings when scrolling impossible
6 years, 8 months ago (2014-04-01 04:16:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/213743004/1
6 years, 8 months ago (2014-04-01 04:16:36 UTC) #2
commit-bot: I haz the power
Change committed as 260773
6 years, 8 months ago (2014-04-01 04:17:42 UTC) #3
jdduke (slow)
6 years, 8 months ago (2014-04-02 15:37:25 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/222353002/ by jdduke@chromium.org.

The reason for reverting is: The broken fling layout test has been fixed in:
https://codereview.chromium.org/219243010/.

Powered by Google App Engine
This is Rietveld 408576698