Rename fxjse/ to fxjs/ update files to match class names.

Rename fxjse/ to fxjs/ update files to match class names.

This Cl moves the fxjse/ directory to fxjs/ in anticipation of merging in
fpdfsdk/jsapi. In the process the filenames are updated to better match the
class contents. Static methods are moved to anonymous namespaces as possible.

Committed: https://pdfium.googlesource.com/pdfium/+/08fea801054f3afadb95d0a54efe7da6683c5c5d

[dsinclair, 2016-07-11 20:18:02]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-07-11 20:18:04]

PTAL. Part 1 of moving fpdfsdk/jsapi into fxjs/.

https://codereview.chromium.org/2136213002/diff/1/fxjs/include/cfxjse_value.h
File fxjs/include/cfxjse_value.h (right):

https://codereview.chromium.org/2136213002/diff/1/fxjs/include/cfxjse_value.h...
fxjs/include/cfxjse_value.h:25: FX_BOOL IsUndefined() const;
I moved the implementation of these into the cpp file as I think they make more
sense there. They can be moved back if desired.

[Tom Sepez, 2016-07-11 21:03:27]

https://codereview.chromium.org/2136213002/diff/1/fxjs/cfxjse_class.cpp
File fxjs/cfxjse_class.cpp (right):

https://codereview.chromium.org/2136213002/diff/1/fxjs/cfxjse_class.cpp#newcode1
fxjs/cfxjse_class.cpp:1: // Copyright 2016 PDFium Authors. All rights reserved.
Is there a way to avoid losing the history on this?

[Tom Sepez, 2016-07-11 22:12:28]

https://codereview.chromium.org/2136213002/diff/1/fxjs/include/cfxjse_context.h
File fxjs/include/cfxjse_context.h (right):

https://codereview.chromium.org/2136213002/diff/1/fxjs/include/cfxjse_context...
fxjs/include/cfxjse_context.h:39: friend class
CFXJSE_ScopeUtil_IsolateHandleContext;
I thought you renamed this one.

https://codereview.chromium.org/2136213002/diff/1/fxjs/include/cfxjse_value.h
File fxjs/include/cfxjse_value.h (right):

https://codereview.chromium.org/2136213002/diff/1/fxjs/include/cfxjse_value.h...
fxjs/include/cfxjse_value.h:25: FX_BOOL IsUndefined() const;
On 2016/07/11 20:18:03, dsinclair wrote:
> I moved the implementation of these into the cpp file as I think they make
more
> sense there. They can be moved back if desired.

How heavyweight are these?  If they have scopes and such, then fine to move to
.cpp

[dsinclair, 2016-07-12 13:38:30]

https://codereview.chromium.org/2136213002/diff/1/fxjs/cfxjse_class.cpp
File fxjs/cfxjse_class.cpp (right):

https://codereview.chromium.org/2136213002/diff/1/fxjs/cfxjse_class.cpp#newcode1
fxjs/cfxjse_class.cpp:1: // Copyright 2016 PDFium Authors. All rights reserved.
On 2016/07/11 21:03:27, Tom Sepez wrote:
> Is there a way to avoid losing the history on this?

Looks like similiarity=40 worked.

https://codereview.chromium.org/2136213002/diff/1/fxjs/include/cfxjse_context.h
File fxjs/include/cfxjse_context.h (right):

https://codereview.chromium.org/2136213002/diff/1/fxjs/include/cfxjse_context...
fxjs/include/cfxjse_context.h:39: friend class
CFXJSE_ScopeUtil_IsolateHandleContext;
On 2016/07/11 22:12:28, Tom Sepez wrote:
> I thought you renamed this one.


I moved it, but I didn't rename it. It's moved into the IsolateTracker file as I
think it makes the most sense there.

https://codereview.chromium.org/2136213002/diff/1/fxjs/include/cfxjse_value.h
File fxjs/include/cfxjse_value.h (right):

https://codereview.chromium.org/2136213002/diff/1/fxjs/include/cfxjse_value.h...
fxjs/include/cfxjse_value.h:25: FX_BOOL IsUndefined() const;
On 2016/07/11 22:12:28, Tom Sepez wrote:
> On 2016/07/11 20:18:03, dsinclair wrote:
> > I moved the implementation of these into the cpp file as I think they make
> more
> > sense there. They can be moved back if desired.
> 
> How heavyweight are these?  If they have scopes and such, then fine to move to
> .cpp


Yup, all have scopes:

FX_BOOL CFXJSE_Value::IsUndefined() const {
  if (m_hValue.IsEmpty())
    return FALSE;
 
  CFXJSE_ScopeUtil_IsolateHandle scope(m_pIsolate);
  v8::Local<v8::Value> hValue = v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
  return hValue->IsUndefined();
}

[Tom Sepez, 2016-07-12 16:35:37]

lgtm

https://codereview.chromium.org/2136213002/diff/20001/fxjs/cfxjse_context.cpp
File fxjs/cfxjse_context.cpp (right):

https://codereview.chromium.org/2136213002/diff/20001/fxjs/cfxjse_context.cpp...
fxjs/cfxjse_context.cpp:44: // in cfxjse_context.h
nit: add a todo to remove the friending.

[dsinclair, 2016-07-12 17:22:20]

https://codereview.chromium.org/2136213002/diff/20001/fxjs/cfxjse_context.cpp
File fxjs/cfxjse_context.cpp (right):

https://codereview.chromium.org/2136213002/diff/20001/fxjs/cfxjse_context.cpp...
fxjs/cfxjse_context.cpp:44: // in cfxjse_context.h
On 2016/07/12 16:35:37, Tom Sepez wrote:
> nit: add a todo to remove the friending.

Done.

[dsinclair, 2016-07-12 17:22:29]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-12 17:22:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2136213002/#ps40001
(title: "Add todo")

[commit-bot: I haz the power, 2016-07-12 17:22:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 17:37:56]

Description was changed from

==========
Rename fxjse/ to fxjs/ update files to match class names.

This Cl moves the fxjse/ directory to fxjs/ in anticipation of merging in
fpdfsdk/jsapi. In the process the filenames are updated to better match the
class contents. Static methods are moved to anonymous namespaces as possible.
==========

to

==========
Rename fxjse/ to fxjs/ update files to match class names.

This Cl moves the fxjse/ directory to fxjs/ in anticipation of merging in
fpdfsdk/jsapi. In the process the filenames are updated to better match the
class contents. Static methods are moved to anonymous namespaces as possible.

Committed:
https://pdfium.googlesource.com/pdfium/+/08fea801054f3afadb95d0a54efe7da6683c...
==========

[commit-bot: I haz the power, 2016-07-12 17:37:57]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/08fea801054f3afadb95d0a54efe7da6683c...