Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2135973003: [interpreter] Widen set of applied binary op reductions. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-typed-lowering-6
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Widen set of applied binary op reductions. This widens the set of binary operator reductions that are applied by TurboFan when graphs are built from bytecode. By now we only insert number conversions to inputs of integer binary ops (i.e. bitwise and shifts), others no longer require a "before" frame state input. R=bmeurer@chromium.org Committed: https://crrev.com/570e88406f790852e8eb5363155044a5cdc6ed63 Cr-Commit-Position: refs/heads/master@{#37674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 10 chunks +2 lines, -15 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
Michael Starzinger
Benedikt: PTAL. Ross: FYI.
4 years, 5 months ago (2016-07-11 12:31:48 UTC) #3
Benedikt Meurer
Nice, LGTM. Thanks!
4 years, 5 months ago (2016-07-11 12:53:04 UTC) #4
rmcilroy
LGTM, thanks!
4 years, 5 months ago (2016-07-11 13:02:22 UTC) #5
Jarin
lgtm
4 years, 5 months ago (2016-07-12 09:30:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135973003/1
4 years, 5 months ago (2016-07-12 10:29:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 10:31:20 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 10:34:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/570e88406f790852e8eb5363155044a5cdc6ed63
Cr-Commit-Position: refs/heads/master@{#37674}

Powered by Google App Engine
This is Rietveld 408576698