Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 2135973003: [interpreter] Widen set of applied binary op reductions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-typed-lowering-6
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-typed-lowering.cc
diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc
index 985a31e7db80b671b21c80ca9b4fc884266c9fbc..7d0428bd55fd702a030e2d1b0b562cbec0cd2b00 100644
--- a/src/compiler/js-typed-lowering.cc
+++ b/src/compiler/js-typed-lowering.cc
@@ -433,10 +433,7 @@ JSTypedLowering::JSTypedLowering(Editor* editor,
Reduction JSTypedLowering::ReduceJSAdd(Node* node) {
- if (flags() & kDisableBinaryOpReduction) return NoChange();
-
JSBinopReduction r(this, node);
-
BinaryOperationHints::Hint feedback = r.GetNumberBinaryOperationFeedback();
if (feedback == BinaryOperationHints::kNumberOrUndefined &&
r.BothInputsAre(Type::PlainPrimitive()) &&
@@ -487,7 +484,6 @@ Reduction JSTypedLowering::ReduceJSAdd(Node* node) {
Reduction JSTypedLowering::ReduceJSSubtract(Node* node) {
- if (flags() & kDisableBinaryOpReduction) return NoChange();
JSBinopReduction r(this, node);
BinaryOperationHints::Hint feedback = r.GetNumberBinaryOperationFeedback();
if (feedback == BinaryOperationHints::kNumberOrUndefined &&
@@ -516,7 +512,6 @@ Reduction JSTypedLowering::ReduceJSSubtract(Node* node) {
}
Reduction JSTypedLowering::ReduceJSMultiply(Node* node) {
- if (flags() & kDisableBinaryOpReduction) return NoChange();
JSBinopReduction r(this, node);
BinaryOperationHints::Hint feedback = r.GetNumberBinaryOperationFeedback();
if (feedback != BinaryOperationHints::kAny) {
@@ -536,7 +531,6 @@ Reduction JSTypedLowering::ReduceJSMultiply(Node* node) {
}
Reduction JSTypedLowering::ReduceJSDivide(Node* node) {
- if (flags() & kDisableBinaryOpReduction) return NoChange();
JSBinopReduction r(this, node);
BinaryOperationHints::Hint feedback = r.GetNumberBinaryOperationFeedback();
if (feedback == BinaryOperationHints::kNumberOrUndefined &&
@@ -560,7 +554,6 @@ Reduction JSTypedLowering::ReduceJSDivide(Node* node) {
}
Reduction JSTypedLowering::ReduceJSModulus(Node* node) {
- if (flags() & kDisableBinaryOpReduction) return NoChange();
JSBinopReduction r(this, node);
BinaryOperationHints::Hint feedback = r.GetNumberBinaryOperationFeedback();
if (feedback == BinaryOperationHints::kNumberOrUndefined &&
@@ -586,7 +579,7 @@ Reduction JSTypedLowering::ReduceJSModulus(Node* node) {
}
Reduction JSTypedLowering::ReduceInt32Binop(Node* node, const Operator* intOp) {
- if (flags() & kDisableBinaryOpReduction) return NoChange();
+ if (flags() & kDisableIntegerBinaryOpReduction) return NoChange();
JSBinopReduction r(this, node);
r.ConvertInputsToNumber();
@@ -598,7 +591,7 @@ Reduction JSTypedLowering::ReduceInt32Binop(Node* node, const Operator* intOp) {
Reduction JSTypedLowering::ReduceUI32Shift(Node* node,
Signedness left_signedness,
const Operator* shift_op) {
- if (flags() & kDisableBinaryOpReduction) return NoChange();
+ if (flags() & kDisableIntegerBinaryOpReduction) return NoChange();
JSBinopReduction r(this, node);
r.ConvertInputsToNumber();
@@ -608,8 +601,6 @@ Reduction JSTypedLowering::ReduceUI32Shift(Node* node,
Reduction JSTypedLowering::ReduceJSComparison(Node* node) {
- if (flags() & kDisableBinaryOpReduction) return NoChange();
-
JSBinopReduction r(this, node);
if (r.BothInputsAre(Type::String())) {
// If both inputs are definitely strings, perform a string comparison.
@@ -721,8 +712,6 @@ Reduction JSTypedLowering::ReduceJSEqualTypeOf(Node* node, bool invert) {
}
Reduction JSTypedLowering::ReduceJSEqual(Node* node, bool invert) {
- if (flags() & kDisableBinaryOpReduction) return NoChange();
-
Reduction const reduction = ReduceJSEqualTypeOf(node, invert);
if (reduction.Changed()) {
ReplaceWithValue(node, reduction.replacement());
@@ -765,8 +754,6 @@ Reduction JSTypedLowering::ReduceJSEqual(Node* node, bool invert) {
Reduction JSTypedLowering::ReduceJSStrictEqual(Node* node, bool invert) {
- if (flags() & kDisableBinaryOpReduction) return NoChange();
-
JSBinopReduction r(this, node);
if (r.left() == r.right()) {
// x === x is always true if x != NaN
« no previous file with comments | « src/compiler/js-typed-lowering.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698