Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2134173002: [turbofan] Remove eager frame state from comparisons. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove eager frame state from comparisons. This removes the frame state input representing the before-state from nodes having any comparison operator. Lowering that inserts number conversions of the inputs has to be disabled when deoptimization is enabled, because the frame state layout is no longer known. R=jarin@chromium.org BUG=v8:5021 Committed: https://crrev.com/136e60a7cecc5d98e4573f064f233d8b0ca30f49 Cr-Commit-Position: refs/heads/master@{#37646}

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M src/compiler/operator-properties.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-11 12:20:59 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-07-11 12:58:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2134173002/20001
4 years, 5 months ago (2016-07-11 14:24:02 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 14:25:37 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 14:25:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/136e60a7cecc5d98e4573f064f233d8b0ca30f49
Cr-Commit-Position: refs/heads/master@{#37646}

Powered by Google App Engine
This is Rietveld 408576698