src/ia32/lithium-codegen-ia32.cc - Issue 21357003: Stores to external references don't need write barriers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 21357003: Stores to external references don't need write barriers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 0d20dea90ae793223117aaea6e680ba38ce22b29..013a921c5f9f75662fe78c8ba7209dab5160bb66 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -4342,6 +4342,7 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {

int offset = access.offset();

if (access.IsExternalMemory()) {

+ ASSERT(!instr->hydrogen()->NeedsWriteBarrier());

mvstanton 2013/07/31 13:37:47 This assert should be in the other platforms too.

Michael Starzinger 2013/07/31 13:40:19 nit: Can we add the same assert to the x64 port as

Benedikt Meurer 2013/07/31 13:45:39 Done.

MemOperand operand = instr->object()->IsConstantOperand()

? MemOperand::StaticVariable(

ToExternalReference(LConstantOperand::cast(instr->object())))