Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2012 the V8 project authors. All rights reserved. | 1 // Copyright 2012 the V8 project authors. All rights reserved. |
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
| 4 // met: | 4 // met: |
| 5 // | 5 // |
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
| (...skipping 4324 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 4335 } | 4335 } |
| 4336 | 4336 |
| 4337 | 4337 |
| 4338 void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) { | 4338 void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) { |
| 4339 Representation representation = instr->representation(); | 4339 Representation representation = instr->representation(); |
| 4340 | 4340 |
| 4341 HObjectAccess access = instr->hydrogen()->access(); | 4341 HObjectAccess access = instr->hydrogen()->access(); |
| 4342 int offset = access.offset(); | 4342 int offset = access.offset(); |
| 4343 | 4343 |
| 4344 if (access.IsExternalMemory()) { | 4344 if (access.IsExternalMemory()) { |
| 4345 ASSERT(!instr->hydrogen()->NeedsWriteBarrier()); | |
|
mvstanton
2013/07/31 13:37:47
This assert should be in the other platforms too.
Michael Starzinger
2013/07/31 13:40:19
nit: Can we add the same assert to the x64 port as
Benedikt Meurer
2013/07/31 13:45:39
Done.
| |
| 4345 MemOperand operand = instr->object()->IsConstantOperand() | 4346 MemOperand operand = instr->object()->IsConstantOperand() |
| 4346 ? MemOperand::StaticVariable( | 4347 ? MemOperand::StaticVariable( |
| 4347 ToExternalReference(LConstantOperand::cast(instr->object()))) | 4348 ToExternalReference(LConstantOperand::cast(instr->object()))) |
| 4348 : MemOperand(ToRegister(instr->object()), offset); | 4349 : MemOperand(ToRegister(instr->object()), offset); |
| 4349 if (instr->value()->IsConstantOperand()) { | 4350 if (instr->value()->IsConstantOperand()) { |
| 4350 LConstantOperand* operand_value = LConstantOperand::cast(instr->value()); | 4351 LConstantOperand* operand_value = LConstantOperand::cast(instr->value()); |
| 4351 __ mov(operand, Immediate(ToInteger32(operand_value))); | 4352 __ mov(operand, Immediate(ToInteger32(operand_value))); |
| 4352 } else { | 4353 } else { |
| 4353 Register value = ToRegister(instr->value()); | 4354 Register value = ToRegister(instr->value()); |
| 4354 __ mov(operand, value); | 4355 __ mov(operand, value); |
| (...skipping 2157 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 6512 FixedArray::kHeaderSize - kPointerSize)); | 6513 FixedArray::kHeaderSize - kPointerSize)); |
| 6513 __ bind(&done); | 6514 __ bind(&done); |
| 6514 } | 6515 } |
| 6515 | 6516 |
| 6516 | 6517 |
| 6517 #undef __ | 6518 #undef __ |
| 6518 | 6519 |
| 6519 } } // namespace v8::internal | 6520 } } // namespace v8::internal |
| 6520 | 6521 |
| 6521 #endif // V8_TARGET_ARCH_IA32 | 6522 #endif // V8_TARGET_ARCH_IA32 |
| OLD | NEW |