Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: src/ia32/lithium-ia32.cc

Issue 21357003: Stores to external references don't need write barriers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/lithium-ia32.cc
diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc
index 7edf2d9f3e0a4148c047da290fbd38c9fb35af9a..91c41110828eaaa17365c84640a63b9fb74ff39c 100644
--- a/src/ia32/lithium-ia32.cc
+++ b/src/ia32/lithium-ia32.cc
@@ -2422,15 +2422,15 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) {
instr->NeedsWriteBarrierForMap();
LOperand* obj;
- if (needs_write_barrier) {
- obj = is_in_object
- ? UseRegister(instr->object())
- : UseTempRegister(instr->object());
- } else if (is_external_location) {
+ if (is_external_location) {
ASSERT(!is_in_object);
ASSERT(!needs_write_barrier);
ASSERT(!needs_write_barrier_for_map);
obj = UseRegisterOrConstant(instr->object());
+ } else if (needs_write_barrier) {
+ obj = is_in_object
+ ? UseRegister(instr->object())
mvstanton 2013/07/31 13:37:47 Is this reordering needed? If so, do you need to m
Benedikt Meurer 2013/07/31 13:45:39 Nope.
+ : UseTempRegister(instr->object());
} else {
obj = needs_write_barrier_for_map
? UseRegister(instr->object())

Powered by Google App Engine
This is Rietveld 408576698