Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2135673002: Don't scissor draws overlapping the render target's edges (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@hidebounds
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't scissor draws overlapping the render target's edges GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135673002 Committed: https://skia.googlesource.com/skia/+/bd2bbe4a1750166136c7729adb0b48ebd7132b74

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M include/gpu/GrClip.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 6 chunks +25 lines, -26 lines 2 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
bsalomon
4 years, 5 months ago (2016-07-08 13:38:19 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2135673002/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/2135673002/diff/1/src/gpu/GrClipMaskManager.cpp#newcode246 src/gpu/GrClipMaskManager.cpp:246: if (origDevBounds) { Are there any issues with ...
4 years, 5 months ago (2016-07-08 14:21:58 UTC) #8
bsalomon
https://codereview.chromium.org/2135673002/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/2135673002/diff/1/src/gpu/GrClipMaskManager.cpp#newcode246 src/gpu/GrClipMaskManager.cpp:246: if (origDevBounds) { On 2016/07/08 14:21:58, robertphillips wrote: > ...
4 years, 5 months ago (2016-07-08 14:25:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135673002/1
4 years, 5 months ago (2016-07-08 14:35:50 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:36:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bd2bbe4a1750166136c7729adb0b48ebd7132b74

Powered by Google App Engine
This is Rietveld 408576698