Use clipped bounds for reordering decisions

Use clipped bounds for reordering decisions
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002

NOTREECHECKS=true
NOPRESUBMIT=true

Committed: https://skia.googlesource.com/skia/+/6cc9006a907bf166b94468bf5c0e915cc0b14532

[bsalomon, 2016-07-08 14:37:51]

Description was changed from

==========
Use clipped bounds for reordering decisions
==========

to

==========
Use clipped bounds for reordering decisions
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002
==========

[bsalomon, 2016-07-08 14:51:18]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-07-08 15:46:14]

lgtm

https://codereview.chromium.org/2137543002/diff/20001/include/gpu/GrClip.h
File include/gpu/GrClip.h (right):

https://codereview.chromium.org/2137543002/diff/20001/include/gpu/GrClip.h#ne...
include/gpu/GrClip.h:88: */
SkASSERT(!fDeviceBounds.isLargest());

?

https://codereview.chromium.org/2137543002/diff/20001/include/gpu/GrClip.h#ne...
include/gpu/GrClip.h:152: fDeviceBounds = deviceBounds;
We don't need an "if (fScissorState.enabled())" guard around this assert ?

i.e., would we ever reset() and then enableStencilClip ?

https://codereview.chromium.org/2137543002/diff/20001/src/gpu/GrClip.cpp
File src/gpu/GrClip.cpp (right):

https://codereview.chromium.org/2137543002/diff/20001/src/gpu/GrClip.cpp#newc...
src/gpu/GrClip.cpp:46: const SkRect* devBounds, GrAppliedClip* out) const {
SkASSERT(!fDeviceBounds.isLargest());

?

https://codereview.chromium.org/2137543002/diff/20001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/2137543002/diff/20001/src/gpu/GrDrawTarget.h#...
src/gpu/GrDrawTarget.h:220: };
line up fRecordedBatches with others
?

[bsalomon, 2016-07-08 17:06:44]

https://codereview.chromium.org/2137543002/diff/20001/include/gpu/GrClip.h
File include/gpu/GrClip.h (right):

https://codereview.chromium.org/2137543002/diff/20001/include/gpu/GrClip.h#ne...
include/gpu/GrClip.h:88: */
On 2016/07/08 15:46:14, robertphillips wrote:
> SkASSERT(!fDeviceBounds.isLargest());
> 
> ?

It can be largest if the clip can be ignored. GrCMM will never add a scissor,
fp, or stencil to the GrAppliedClip, leaving it with largest.

https://codereview.chromium.org/2137543002/diff/20001/include/gpu/GrClip.h#ne...
include/gpu/GrClip.h:152: fDeviceBounds = deviceBounds;
On 2016/07/08 15:46:14, robertphillips wrote:
> We don't need an "if (fScissorState.enabled())" guard around this assert ?
> 
> i.e., would we ever reset() and then enableStencilClip ?

Done.

https://codereview.chromium.org/2137543002/diff/20001/src/gpu/GrClip.cpp
File src/gpu/GrClip.cpp (right):

https://codereview.chromium.org/2137543002/diff/20001/src/gpu/GrClip.cpp#newc...
src/gpu/GrClip.cpp:46: const SkRect* devBounds, GrAppliedClip* out) const {
On 2016/07/08 15:46:14, robertphillips wrote:
> SkASSERT(!fDeviceBounds.isLargest());
> 
> ?

Done.

https://codereview.chromium.org/2137543002/diff/20001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/2137543002/diff/20001/src/gpu/GrDrawTarget.h#...
src/gpu/GrDrawTarget.h:220: };
On 2016/07/08 15:46:14, robertphillips wrote:
> line up fRecordedBatches with others
> ?

Done.

[bsalomon, 2016-07-08 17:06:55]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 17:07:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 17:12:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 17:12:56]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[bsalomon, 2016-07-08 17:16:55]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 17:17:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsalomon, 2016-07-08 17:20:50]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2016-07-08 17:21:36]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-07-08 17:21:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2137543002/#ps60001
(title: "fix windows warning")

[commit-bot: I haz the power, 2016-07-08 17:21:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsalomon, 2016-07-08 18:18:17]

Description was changed from

==========
Use clipped bounds for reordering decisions
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002
==========

to

==========
Use clipped bounds for reordering decisions
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002

NOTREECHECKS=true
==========

[bsalomon, 2016-07-08 18:18:27]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2016-07-08 18:18:28]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-07-08 18:18:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsalomon, 2016-07-08 18:30:31]

Description was changed from

==========
Use clipped bounds for reordering decisions
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002

NOTREECHECKS=true
==========

to

==========
Use clipped bounds for reordering decisions
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002

NOTREECHECKS=true
NOPRESUBMIT=true
==========

[bsalomon, 2016-07-08 18:30:36]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2016-07-08 18:30:42]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-07-08 18:30:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 18:31:26]

Description was changed from

==========
Use clipped bounds for reordering decisions
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002

NOTREECHECKS=true
NOPRESUBMIT=true
==========

to

==========
Use clipped bounds for reordering decisions
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002

NOTREECHECKS=true
NOPRESUBMIT=true

Committed:
https://skia.googlesource.com/skia/+/6cc9006a907bf166b94468bf5c0e915cc0b14532
==========

[commit-bot: I haz the power, 2016-07-08 18:31:27]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6cc9006a907bf166b94468bf5c0e915cc0b14532