Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2127673002: Consolidate handling of infinitely thin primitives and aa bloat handing WRT batch bounds (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@AAStrokeRect
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Consolidate handling of infinitely thin primitives and aa bloat handing WRT batch bounds. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127673002 Committed: https://skia.googlesource.com/skia/+/88cf17d099085b8085ab11571b5094163dbb2c84

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : more #

Patch Set 4 : more #

Patch Set 5 : more #

Patch Set 6 : remove unneeded outset #

Patch Set 7 : common bounds function #

Patch Set 8 : assert batch class id #

Patch Set 9 : comments #

Total comments: 12

Patch Set 10 : Address comments #

Patch Set 11 : revert accidental comment change #

Patch Set 12 : update for instanced rendering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -133 lines) Patch
M src/gpu/GrDrawTarget.cpp View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +42 lines, -7 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 3 4 5 6 7 8 9 10 chunks +21 lines, -16 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.h View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 1 2 3 4 5 6 7 8 4 chunks +71 lines, -9 lines 0 comments Download
M src/gpu/batches/GrBatch.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/batches/GrClearBatch.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrCopySurfaceBatch.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M src/gpu/batches/GrDiscardBatch.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.cpp View 1 2 3 4 5 2 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.cpp View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.cpp View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/batches/GrNinePatch.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrNonAAFillRectBatch.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrNonAAFillRectPerspectiveBatch.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrNonAAStrokeRectBatch.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +12 lines, -11 lines 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrStencilPathBatch.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
M src/gpu/batches/GrTestBatch.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M src/gpu/instanced/InstancedRendering.cpp View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +17 lines, -9 lines 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2135673002 Patch 1

Messages

Total messages: 16 (9 generated)
bsalomon
4 years, 5 months ago (2016-07-07 19:37:16 UTC) #4
robertphillips
https://codereview.chromium.org/2127673002/diff/160001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/2127673002/diff/160001/src/gpu/GrOvalRenderer.cpp#newcode574 src/gpu/GrOvalRenderer.cpp:574: }); Isn't this wrong for stroked circles ? https://codereview.chromium.org/2127673002/diff/160001/src/gpu/batches/GrAAConvexPathRenderer.cpp ...
4 years, 5 months ago (2016-07-07 20:26:42 UTC) #5
bsalomon
https://codereview.chromium.org/2127673002/diff/160001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/2127673002/diff/160001/src/gpu/GrOvalRenderer.cpp#newcode574 src/gpu/GrOvalRenderer.cpp:574: }); On 2016/07/07 20:26:42, robertphillips wrote: > Isn't this ...
4 years, 5 months ago (2016-07-07 23:40:57 UTC) #6
robertphillips
lgtm
4 years, 5 months ago (2016-07-08 13:37:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127673002/220001
4 years, 5 months ago (2016-07-08 13:39:45 UTC) #13
commit-bot: I haz the power
Committed patchset #12 (id:220001) as https://skia.googlesource.com/skia/+/88cf17d099085b8085ab11571b5094163dbb2c84
4 years, 5 months ago (2016-07-08 13:41:00 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 13:41:02 UTC) #16
Message was sent while issue was closed. 
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698