Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2135573004: [Payments] Add ability to bold parts of addresses (Closed)

Created:
4 years, 5 months ago by gone
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@payments_continuing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Add ability to bold parts of addresses * Add the ability to bold parts of a label. * Add the ability to show a tertiary label in the PaymentOption, which will later be used for phone number display. * The phone number is passed in to the PaymentOption using the new constructor via the AutofillAddress class. See crbug.com/626833 for screenshots. BUG=603635, 626833 Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f Committed: https://crrev.com/1089ca591550d0ca24befe3023b369a5ed2944da Cr-Original-Commit-Position: refs/heads/master@{#405900} Cr-Commit-Position: refs/heads/master@{#406062}

Patch Set 1 #

Patch Set 2 : Adding rouslan's changes #

Patch Set 3 : Rebase #

Patch Set 4 : Phone number fix #

Messages

Total messages: 33 (15 generated)
gone
Nothing crazy going on here, UI-wise.
4 years, 5 months ago (2016-07-08 23:38:22 UTC) #3
please use gerrit instead
This will conflict with the credit card editor patch that I'm about to submit. Let's ...
4 years, 5 months ago (2016-07-12 14:10:21 UTC) #4
gone
Added your changes from https://codereview.chromium.org/2149433002/ and reuploaded to this original issue. PTAL; I'll wait to ...
4 years, 5 months ago (2016-07-15 00:19:44 UTC) #6
please use gerrit instead
lgtm
4 years, 5 months ago (2016-07-15 00:38:24 UTC) #7
please use gerrit instead
mathp@, ptal personal_data_manager*
4 years, 5 months ago (2016-07-15 00:38:48 UTC) #9
Mathieu
lgtm
4 years, 5 months ago (2016-07-15 13:06:43 UTC) #10
gone
Rouslan: can you take another look? Rebase required some changes.
4 years, 5 months ago (2016-07-15 23:02:20 UTC) #12
please use gerrit instead
lgtm
4 years, 5 months ago (2016-07-15 23:04:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135573004/60001
4 years, 5 months ago (2016-07-15 23:08:05 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-15 23:40:42 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 23:40:52 UTC) #21
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f Cr-Commit-Position: refs/heads/master@{#405900}
4 years, 5 months ago (2016-07-15 23:42:22 UTC) #23
markusheintz_
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2158763002/ by markusheintz@chromium.org. ...
4 years, 5 months ago (2016-07-18 08:25:57 UTC) #24
please use gerrit instead
The other CL turned out to be the culprit. It's being re-landed with a fix ...
4 years, 5 months ago (2016-07-18 17:00:23 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135573004/60001
4 years, 5 months ago (2016-07-18 18:14:28 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-18 19:29:29 UTC) #30
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 19:29:41 UTC) #31
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 19:31:08 UTC) #33
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1089ca591550d0ca24befe3023b369a5ed2944da
Cr-Commit-Position: refs/heads/master@{#406062}

Powered by Google App Engine
This is Rietveld 408576698