chrome/browser/autofill/android/personal_data_manager_android.h - Issue 2135573004: [Payments] Add ability to bold parts of addresses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.h

Issue 2135573004: [Payments] Add ability to bold parts of addresses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@payments_continuing

Patch Set: Phone number fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java ('k') | chrome/browser/autofill/android/personal_data_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/android/personal_data_manager_android.h

diff --git a/chrome/browser/autofill/android/personal_data_manager_android.h b/chrome/browser/autofill/android/personal_data_manager_android.h

index 01dde27c035724b71f2a77f20e9056a8914625bb..9a05ce69e6d584857853bba63c44292de3e2a042 100644

--- a/chrome/browser/autofill/android/personal_data_manager_android.h

+++ b/chrome/browser/autofill/android/personal_data_manager_android.h

@@ -61,8 +61,8 @@ class PersonalDataManagerAndroid : public PersonalDataManagerObserver {

// Gets the labels for the profiles to suggest to the user. These labels are

// useful for distinguishing the profiles from one another.

- // The labels never contain the full name or email address. All other fields

- // are included in the label.

+ // The labels never contain the full name, email address, or phone numbers.

+ // All other fields are included in the label.

base::android::ScopedJavaLocalRef<jobjectArray> GetProfileLabelsToSuggest(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& unused_obj);

@@ -221,8 +221,8 @@ class PersonalDataManagerAndroid : public PersonalDataManagerObserver {

// The labels never contain the full name and include at least 2 fields.

- // If |address_only| is true, then such fields as phone number and email

- // address are also omitted, but all fields are included in the label.

+ // If |address_only| is true, then such fields as phone number, and email

+ // address are also omitted, but all other fields are included in the label.

base::android::ScopedJavaLocalRef<jobjectArray> GetProfileLabels(

JNIEnv* env,

bool address_only,