Credit card editor for PaymentRequest UI.

Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924
Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Committed: https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4
Cr-Original-Commit-Position: refs/heads/master@{#405876}
Cr-Commit-Position: refs/heads/master@{#406036}

[please use gerrit instead, 2016-06-30 21:00:01]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

BUG=603635
==========

to

==========
Credit card editor for PaymentRequest UI.

BUG=624924
==========

[please use gerrit instead, 2016-07-01 04:31:42]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-07-01 04:31:49]

Patchset #1 (id:20001) has been deleted

[please use gerrit instead, 2016-07-01 04:31:56]

Patchset #1 (id:40001) has been deleted

[please use gerrit instead, 2016-07-01 07:13:15]

Patchset #1 (id:40002) has been deleted

[please use gerrit instead, 2016-07-04 09:55:32]

Patchset #1 (id:70001) has been deleted

[please use gerrit instead, 2016-07-04 09:55:40]

Patchset #1 (id:90001) has been deleted

[please use gerrit instead, 2016-07-04 14:01:56]

Patchset #1 (id:110001) has been deleted

[please use gerrit instead, 2016-07-04 14:02:06]

Patchset #1 (id:130001) has been deleted

[please use gerrit instead, 2016-07-05 08:53:42]

Patchset #1 (id:150001) has been deleted

[please use gerrit instead, 2016-07-05 08:53:51]

Patchset #1 (id:170001) has been deleted

[please use gerrit instead, 2016-07-05 09:05:48]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

BUG=624924
==========

to

==========
Credit card editor for PaymentRequest UI.

=== ICONS ===

- Adds icons for UnionPay, JCB, and Diners for PaymentRequest. Autofill
  is not using the new icons.

=== LAYOUTS ===

- Adds a layout for showing a list of icons, used for showing the
  credit card types that the merchant accepts.

- Adds a layout for showing three-labels on the left and one icon to the
  right of the labels, used to show information about a server credit
  card, when editing it's billing address.

=== CREDIT CARD OBJECT ===

- Allows creation of a Java CreditCard object without specifying any
  parameters.

- Allows updating the card type and icon after the card has been edited.

=== PERSONAL DATA MANAGER ===

- Adds a PersonalDataManager to retrieve credit card icon, type, and
  obfuscated number when given the full card number. Used to update card
  display after user has edited a card.

- Adds a PersonalDataManager method to run the Luhn check on the card.
  If the Luhn check passes, the method returns the card type, which is
  used to validate the card against the card types that the merchant
  supports.

- Adds a PersonalDataManager method to retrieve the full card details
  for a temporary card that's not stored on disk. The card editor saves
  the card on disk only if the user selects the "Save this card on this
  device" checkbox. (The existing API to retrieve the card details
  assumes the card is already on disk. It updates the save card
  expiration date, if the user changes it.)

BUG=624924
==========

[please use gerrit instead, 2016-07-05 09:09:42]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

=== ICONS ===

- Adds icons for UnionPay, JCB, and Diners for PaymentRequest. Autofill
  is not using the new icons.

=== LAYOUTS ===

- Adds a layout for showing a list of icons, used for showing the
  credit card types that the merchant accepts.

- Adds a layout for showing three-labels on the left and one icon to the
  right of the labels, used to show information about a server credit
  card, when editing it's billing address.

=== CREDIT CARD OBJECT ===

- Allows creation of a Java CreditCard object without specifying any
  parameters.

- Allows updating the card type and icon after the card has been edited.

=== PERSONAL DATA MANAGER ===

- Adds a PersonalDataManager to retrieve credit card icon, type, and
  obfuscated number when given the full card number. Used to update card
  display after user has edited a card.

- Adds a PersonalDataManager method to run the Luhn check on the card.
  If the Luhn check passes, the method returns the card type, which is
  used to validate the card against the card types that the merchant
  supports.

- Adds a PersonalDataManager method to retrieve the full card details
  for a temporary card that's not stored on disk. The card editor saves
  the card on disk only if the user selects the "Save this card on this
  device" checkbox. (The existing API to retrieve the card details
  assumes the card is already on disk. It updates the save card
  expiration date, if the user changes it.)

BUG=624924
==========

to

==========
Credit card editor for PaymentRequest UI.

=== ICONS ===

- Adds icons for UnionPay, JCB, and Diners for PaymentRequest. Autofill
  is not using the new icons.

=== LAYOUTS ===

- Adds a layout for showing a list of icons, used for showing the
  credit card types that the merchant accepts.

- Adds a layout for showing three-labels on the left and one icon to the
  right of the labels, used to show information about a server credit
  card, when editing it's billing address.

=== CREDIT CARD OBJECT ===

- Allows creation of a Java CreditCard object without specifying any
  parameters.

- Allows updating the card type and icon after the card has been edited.

=== PERSONAL DATA MANAGER ===

- Adds a PersonalDataManager to retrieve credit card icon, type, and
  obfuscated number when given the full card number. Used to update card
  display after user has edited a card.

- Adds a PersonalDataManager method to run the Luhn check on the card.
  If the Luhn check passes, the method returns the card type, which is
  used to validate the card against the card types that the merchant
  supports.

- Adds a PersonalDataManager method to retrieve the full card details
  for a temporary card that's not stored on disk. The card editor saves
  the card on disk only if the user selects the "Save this card on this
  device" checkbox. (The existing API to retrieve the card details
  assumes the card is already on disk. It updates the save card
  expiration date, if the user changes it.)

=== EDITOR FIELD MODEL ===

- Replaces the large number of obscure constructors with factory methods
  that have clearer names, e.g., createDropdown(), createTextInput().

=== ADDRESS EDITOR ===

- Sets the GUID of the address object after it has been created.
  Necessary to correctly set the billing address of a card after the
  user has selected the "Add address" option in the "Billing address"
  dropdown.

BUG=624924
==========

[please use gerrit instead, 2016-07-05 09:12:07]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

=== ICONS ===

- Adds icons for UnionPay, JCB, and Diners for PaymentRequest. Autofill
  is not using the new icons.

=== LAYOUTS ===

- Adds a layout for showing a list of icons, used for showing the
  credit card types that the merchant accepts.

- Adds a layout for showing three-labels on the left and one icon to the
  right of the labels, used to show information about a server credit
  card, when editing it's billing address.

=== CREDIT CARD OBJECT ===

- Allows creation of a Java CreditCard object without specifying any
  parameters.

- Allows updating the card type and icon after the card has been edited.

=== PERSONAL DATA MANAGER ===

- Adds a PersonalDataManager to retrieve credit card icon, type, and
  obfuscated number when given the full card number. Used to update card
  display after user has edited a card.

- Adds a PersonalDataManager method to run the Luhn check on the card.
  If the Luhn check passes, the method returns the card type, which is
  used to validate the card against the card types that the merchant
  supports.

- Adds a PersonalDataManager method to retrieve the full card details
  for a temporary card that's not stored on disk. The card editor saves
  the card on disk only if the user selects the "Save this card on this
  device" checkbox. (The existing API to retrieve the card details
  assumes the card is already on disk. It updates the save card
  expiration date, if the user changes it.)

=== EDITOR FIELD MODEL ===

- Replaces the large number of obscure constructors with factory methods
  that have clearer names, e.g., createDropdown(), createTextInput().

=== ADDRESS EDITOR ===

- Sets the GUID of the address object after it has been created.
  Necessary to correctly set the billing address of a card after the
  user has selected the "Add address" option in the "Billing address"
  dropdown.

BUG=624924
==========

to

==========
Credit card editor for PaymentRequest UI.

=== ICONS ===

- Adds icons for UnionPay, JCB, and Diners for PaymentRequest. Autofill
  is not using the new icons.

=== LAYOUTS ===

- Adds a layout for showing a list of icons, used for showing the
  credit card types that the merchant accepts.

- Adds a layout for showing three-labels on the left and one icon to the
  right of the labels, used to show information about a server credit
  card, when editing it's billing address.

=== CREDIT CARD OBJECT ===

- Allows creation of a Java CreditCard object without specifying any
  parameters.

- Allows updating the card type and icon after the card has been edited.

=== PERSONAL DATA MANAGER ===

- Adds a PersonalDataManager to retrieve credit card icon, type, and
  obfuscated number when given the full card number. Used to update card
  display after user has edited a card.

- Adds a PersonalDataManager method to run the Luhn check on the card.
  If the Luhn check passes, the method returns the card type, which is
  used to validate the card against the card types that the merchant
  supports.

- Adds a PersonalDataManager method to retrieve the full card details
  for a temporary card that's not stored on disk. The card editor saves
  the card on disk only if the user selects the "Save this card on this
  device" checkbox. (The existing API to retrieve the card details
  assumes the card is already on disk. It updates the save card
  expiration date, if the user changes it.)

=== EDITOR FIELD MODEL ===

- Replaces the large number of obscure constructors with factory methods
  that have clearer names, e.g., createDropdown(), createTextInput().

=== ADDRESS EDITOR ===

- Sets the GUID of the address object after it has been created.
  Necessary to correctly set the billing address of a card after the
  user has selected the "Add address" option in the "Billing address"
  dropdown.

=== AUTOFILL PAYMENT INSTRUMENT ===

- Adds the notion of a complete payment instrument, which has a valid
  credit card number, a non-empty name on card, and a complete billing
  address. Assumes that the user can pay only with a complete payment
  instrument.

BUG=624924
==========

[please use gerrit instead, 2016-07-05 09:59:42]

Patchset #1 (id:190001) has been deleted

[please use gerrit instead, 2016-07-05 09:59:54]

Patchset #1 (id:210001) has been deleted

[please use gerrit instead, 2016-07-06 07:51:12]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

=== ICONS ===

- Adds icons for UnionPay, JCB, and Diners for PaymentRequest. Autofill
  is not using the new icons.

=== LAYOUTS ===

- Adds a layout for showing a list of icons, used for showing the
  credit card types that the merchant accepts.

- Adds a layout for showing three-labels on the left and one icon to the
  right of the labels, used to show information about a server credit
  card, when editing it's billing address.

=== CREDIT CARD OBJECT ===

- Allows creation of a Java CreditCard object without specifying any
  parameters.

- Allows updating the card type and icon after the card has been edited.

=== PERSONAL DATA MANAGER ===

- Adds a PersonalDataManager to retrieve credit card icon, type, and
  obfuscated number when given the full card number. Used to update card
  display after user has edited a card.

- Adds a PersonalDataManager method to run the Luhn check on the card.
  If the Luhn check passes, the method returns the card type, which is
  used to validate the card against the card types that the merchant
  supports.

- Adds a PersonalDataManager method to retrieve the full card details
  for a temporary card that's not stored on disk. The card editor saves
  the card on disk only if the user selects the "Save this card on this
  device" checkbox. (The existing API to retrieve the card details
  assumes the card is already on disk. It updates the save card
  expiration date, if the user changes it.)

=== EDITOR FIELD MODEL ===

- Replaces the large number of obscure constructors with factory methods
  that have clearer names, e.g., createDropdown(), createTextInput().

=== ADDRESS EDITOR ===

- Sets the GUID of the address object after it has been created.
  Necessary to correctly set the billing address of a card after the
  user has selected the "Add address" option in the "Billing address"
  dropdown.

=== AUTOFILL PAYMENT INSTRUMENT ===

- Adds the notion of a complete payment instrument, which has a valid
  credit card number, a non-empty name on card, and a complete billing
  address. Assumes that the user can pay only with a complete payment
  instrument.

BUG=624924
==========

to

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Off by default, similar
   to how autofill always prompts the user for an explicit action to
   save a new card on disk.

This feature requires many changes in Chrome:

=== ICONS ===

- Adds icons for UnionPay, JCB, and Diners for PaymentRequest. Autofill
  is not using the new icons.

=== LAYOUTS ===

- Adds a layout for showing a list of icons, used for showing the
  credit card types that the merchant accepts.

- Adds a layout for showing three-labels on the left and one icon to the
  right of the labels, used to show information about a server credit
  card, when editing it's billing address.

=== CREDIT CARD OBJECT ===

- Allows creation of a Java CreditCard object without specifying any
  parameters.

- Allows updating the card type and icon after the card has been edited.

=== PERSONAL DATA MANAGER ===

- Enables retrieving credit card icon, type, and obfuscated number based
  on the full card number. Used to update card display after user has
  edited a card.

- Adds Luhn check for card numbers. If the Luhn check passes, the method
  returns the card type, which is used to validate the card against the
  types that the merchant supports.

- Enables retrieving the full card details for a temporary card that's
  not stored on disk. The card editor saves the card on disk only if the
  user selects the "Save this card on this device" checkbox. (The
  existing API to retrieve the card details assumes the card is already
  on disk. It can updates the card expiration date on disk.)

=== EDITOR FIELD MODEL ===

- Replaces the large number of obscure constructors with factory methods
  that have clearer names, e.g., createDropdown(), createTextInput().

- Adds several new types of fields: checkbox, icon list, and credit card
  number.

=== ADDRESS EDITOR ===

- Sets the GUID of the address object after it has been created.
  Necessary to correctly set the billing address of a card after the
  user has selected the "Add address" option in the "Billing address"
  dropdown.

=== AUTOFILL PAYMENT INSTRUMENT ===

- Adds the notion of a complete payment instrument, which has a valid
  credit card number, a non-empty name on card, and a complete billing
  address. Assumes that the user can pay only with a complete payment
  instrument.

BUG=624924
==========

[please use gerrit instead, 2016-07-06 08:10:10]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Off by default, similar
   to how autofill always prompts the user for an explicit action to
   save a new card on disk.

This feature requires many changes in Chrome:

=== ICONS ===

- Adds icons for UnionPay, JCB, and Diners for PaymentRequest. Autofill
  is not using the new icons.

=== LAYOUTS ===

- Adds a layout for showing a list of icons, used for showing the
  credit card types that the merchant accepts.

- Adds a layout for showing three-labels on the left and one icon to the
  right of the labels, used to show information about a server credit
  card, when editing it's billing address.

=== CREDIT CARD OBJECT ===

- Allows creation of a Java CreditCard object without specifying any
  parameters.

- Allows updating the card type and icon after the card has been edited.

=== PERSONAL DATA MANAGER ===

- Enables retrieving credit card icon, type, and obfuscated number based
  on the full card number. Used to update card display after user has
  edited a card.

- Adds Luhn check for card numbers. If the Luhn check passes, the method
  returns the card type, which is used to validate the card against the
  types that the merchant supports.

- Enables retrieving the full card details for a temporary card that's
  not stored on disk. The card editor saves the card on disk only if the
  user selects the "Save this card on this device" checkbox. (The
  existing API to retrieve the card details assumes the card is already
  on disk. It can updates the card expiration date on disk.)

=== EDITOR FIELD MODEL ===

- Replaces the large number of obscure constructors with factory methods
  that have clearer names, e.g., createDropdown(), createTextInput().

- Adds several new types of fields: checkbox, icon list, and credit card
  number.

=== ADDRESS EDITOR ===

- Sets the GUID of the address object after it has been created.
  Necessary to correctly set the billing address of a card after the
  user has selected the "Add address" option in the "Billing address"
  dropdown.

=== AUTOFILL PAYMENT INSTRUMENT ===

- Adds the notion of a complete payment instrument, which has a valid
  credit card number, a non-empty name on card, and a complete billing
  address. Assumes that the user can pay only with a complete payment
  instrument.

BUG=624924
==========

to

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Off by default, similar
   to how autofill always prompts the user for an explicit action to
   save a new card on disk.

This feature requires the following changes in PaymentRequest UI.

=== ICONS ===

- Adds icons for UnionPay, JCB, and Diners for PaymentRequest. Autofill
  is not using the new icons.

=== LAYOUTS ===

- Adds a layout for showing a list of icons, used for showing the
  credit card types that the merchant accepts.

- Adds a layout for showing three-labels on the left and one icon to the
  right of the labels, used to show information about a server credit
  card, when editing it's billing address.

=== CREDIT CARD OBJECT ===

- Allows creation of a Java CreditCard object without specifying any
  parameters.

- Allows updating the card type and icon after the card has been edited.

=== PERSONAL DATA MANAGER ===

- Enables retrieving credit card icon, type, and obfuscated number based
  on the full card number. Used to update card display after user has
  edited a card.

- Adds Luhn check for card numbers. If the Luhn check passes, the method
  returns the card type, which is used to validate the card against the
  types that the merchant supports.

- Enables retrieving the full card details for a temporary card that's
  not stored on disk. The card editor saves the card on disk only if the
  user selects the "Save this card on this device" checkbox. (The
  existing API to retrieve the card details assumes the card is already
  on disk. It can updates the card expiration date on disk.)

=== EDITOR FIELD MODEL ===

- Replaces the large number of obscure constructors with factory methods
  that have clearer names, e.g., createDropdown(), createTextInput().

- Adds several new types of fields: checkbox, icon list, and credit card
  number.

=== ADDRESS EDITOR ===

- Sets the GUID of the address object after it has been created.
  Necessary to correctly set the billing address of a card after the
  user has selected the "Add address" option in the "Billing address"
  dropdown.

=== AUTOFILL PAYMENT INSTRUMENT ===

- Adds the notion of a complete payment instrument, which has a valid
  credit card number, a non-empty name on card, and a complete billing
  address. Assumes that the user can pay only with a complete payment
  instrument.

BUG=624924
==========

[please use gerrit instead, 2016-07-06 08:11:12]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Off by default, similar
   to how autofill always prompts the user for an explicit action to
   save a new card on disk.

This feature requires the following changes in PaymentRequest UI.

=== ICONS ===

- Adds icons for UnionPay, JCB, and Diners for PaymentRequest. Autofill
  is not using the new icons.

=== LAYOUTS ===

- Adds a layout for showing a list of icons, used for showing the
  credit card types that the merchant accepts.

- Adds a layout for showing three-labels on the left and one icon to the
  right of the labels, used to show information about a server credit
  card, when editing it's billing address.

=== CREDIT CARD OBJECT ===

- Allows creation of a Java CreditCard object without specifying any
  parameters.

- Allows updating the card type and icon after the card has been edited.

=== PERSONAL DATA MANAGER ===

- Enables retrieving credit card icon, type, and obfuscated number based
  on the full card number. Used to update card display after user has
  edited a card.

- Adds Luhn check for card numbers. If the Luhn check passes, the method
  returns the card type, which is used to validate the card against the
  types that the merchant supports.

- Enables retrieving the full card details for a temporary card that's
  not stored on disk. The card editor saves the card on disk only if the
  user selects the "Save this card on this device" checkbox. (The
  existing API to retrieve the card details assumes the card is already
  on disk. It can updates the card expiration date on disk.)

=== EDITOR FIELD MODEL ===

- Replaces the large number of obscure constructors with factory methods
  that have clearer names, e.g., createDropdown(), createTextInput().

- Adds several new types of fields: checkbox, icon list, and credit card
  number.

=== ADDRESS EDITOR ===

- Sets the GUID of the address object after it has been created.
  Necessary to correctly set the billing address of a card after the
  user has selected the "Add address" option in the "Billing address"
  dropdown.

=== AUTOFILL PAYMENT INSTRUMENT ===

- Adds the notion of a complete payment instrument, which has a valid
  credit card number, a non-empty name on card, and a complete billing
  address. Assumes that the user can pay only with a complete payment
  instrument.

BUG=624924
==========

to

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Off by default, similar
   to how autofill always prompts the user for an explicit action to
   save a new card on disk.

BUG=624924
==========

[please use gerrit instead, 2016-07-06 09:07:42]

Patchset #1 (id:230001) has been deleted

[please use gerrit instead, 2016-07-12 17:31:15]

Patchset #1 (id:250001) has been deleted

[please use gerrit instead, 2016-07-12 17:31:24]

Patchset #1 (id:270001) has been deleted

[please use gerrit instead, 2016-07-12 17:31:34]

Patchset #1 (id:290001) has been deleted

[please use gerrit instead, 2016-07-12 17:31:43]

Patchset #1 (id:310001) has been deleted

[please use gerrit instead, 2016-07-12 21:01:48]

Patchset #1 (id:330001) has been deleted

[please use gerrit instead, 2016-07-12 21:03:36]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mathp@chromium.org

[please use gerrit instead, 2016-07-12 21:03:38]

dfalcantara@, ptal android.

mathp@, ptal autofill.

Sorry for the huge review. This is a single feature with tests, which required
minor changes in several places in Chrome. I feel it makes more sense
monolithically and should be easier to merge into M-53 as a whole.

[please use gerrit instead, 2016-07-12 23:50:20]

Screenshots in http://crbug.com/624924#c2 and http://crbug.com/624924#c3.

[please use gerrit instead, 2016-07-13 00:24:34]

Patch #2 screenshots in http://crbug.com/624924#c4.

[Mathieu, 2016-07-13 16:32:45]

autofill bits lgtm

https://codereview.chromium.org/2116583002/diff/370001/chrome/browser/autofil...
File chrome/browser/autofill/android/personal_data_manager_android.h (right):

https://codereview.chromium.org/2116583002/diff/370001/chrome/browser/autofil...
chrome/browser/autofill/android/personal_data_manager_android.h:155: // Gets the
CVC for a card that's temporary and not stored on disk. The card
reword? Currently comment says "gets the CVC" while the functions seems to be
doing more.

[please use gerrit instead, 2016-07-13 16:57:45]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2016-07-13 16:57:56]

https://codereview.chromium.org/2116583002/diff/370001/chrome/browser/autofil...
File chrome/browser/autofill/android/personal_data_manager_android.h (right):

https://codereview.chromium.org/2116583002/diff/370001/chrome/browser/autofil...
chrome/browser/autofill/android/personal_data_manager_android.h:155: // Gets the
CVC for a card that's temporary and not stored on disk. The card
On 2016/07/13 16:32:45, Mathieu Perreault wrote:
> reword? Currently comment says "gets the CVC" while the functions seems to be
> doing more.

Reworded.

[commit-bot: I haz the power, 2016-07-13 16:58:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 18:04:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:04:44]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2016-07-13 21:06:31]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 21:07:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-07-13 21:13:01]

Long way to go on the review, still, but my eyes were already glazing over a
lot.  Taking a break, but sending what I've got.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File chrome/android/java/res/layout/payment_request_editor_icons.xml (right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_icons.xml:26:
android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding">
Just use /> instead of adding the other closing LinearLayout tag.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File chrome/android/java/res/layout/payment_request_editor_label.xml (right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_label.xml:10:
android:paddingBottom="@dimen/pref_autofill_content_spacing"
Use margins when separating items from other items, not padding.  This currently
knocks the icon off-center.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_label.xml:19:
android:importantForAccessibility="no"
Group the android:layout_ attributes together

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_label.xml:27:
android:layout_alignParentStart="true"
Should this add layout_alignParentTop="true"?

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:358:
public CreditCard() {
Make this constructor call the other one.

this("", AutofillPreferences.SETTINGS_ORIGIN, true, true, "", "", "", "", "",
"", 0, "");

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:50:
/** All card types recognized by this editor. This is a subset of card types in
Full Javadocs don't have sentences on the same line as the /**.  See what you
did for the class comment and do that here.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:91:
* @param webContents     The web contents where the web payments API is invoked.
Should not be
Probably don't need to say "Should not be null" given taht you've got the
asserts and @Nullable annotation for the ones that can be.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:106:
mCardTypes = new HashSet<>();
Makes more sense to have a HashMap containing CardInfos, where each CardInfo
stores drawable IDs and descriptions.  The HashSet functionality in your CL will
be automatic given the HashMap has unique keys, and will avoid having to add
asserts for size equality.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:184:
private EditorFieldValidator getCardNumberValidator() {
Make mCardNumberValidator final and create this in the constructor?  Avoids
having to do the "== null" check each time you grab it.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:237:

Given how often you do toEdit == null, you should just save a

boolean isNewCard = (toEdit == null);

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:240:
final AutofillPaymentInstrument instrument = toEdit == null
really hard to parse; put (toEdit == null ? ....);

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:247:
? R.string.autofill_create_credit_card : R.string.autofill_edit_credit_card));
indentation

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:251:
// The calendar is required only for local cards. Error out if it's not ready.
Can't you save the AsyncTask and then do a .get() on it to wait until it's
finished and return the Calendar?  Beats erroring out.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:398:
Calendar calendar, String alwaysIncludeYear) {
Use: alwaysIncludedYear

"alwaysIncludeYear" sounds like a boolean.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:432:
billingAddresses.add(new DropdownKeyValue("",
pull "" into a constant instead of just commenting about it

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:453:
billingAddresses.add(new DropdownKeyValue("add",
pull "add" into a constant

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:72:
void onPaymentRequestServiceProcessBillingAddressChange();
Changed?

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:111:
* @param label    Label.
top label, middle label, bottom label?  sub implies that it's already below the
regular label, but not necessarily where it is relative to midlabel

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java:22:
private static final int LIST_ICON_SIZE_DP = 38;
Add this to dimens.xml with the other payments dimensions.  Doing
context.getDimensionPixelSize() on that dimension will give you what you then
want instead of doing the crazy calculations on your own

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java:27:
* Builds a horizontal list of icons.
I'm slightly worried about what will happen here when there are too many icons
to fit on screen.  Do they just run off the side?

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java:48:
icon.setMaxWidth((int) (LIST_ICON_SIZE_DP * scale + 0.5f));
Math.round(LIST_ICON_SIZE_DP * scale)

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java:16:
* Helper class for creating a label view.
Describe what a label is because it's more than just what I'd expect to be
called a label.  Maybe draw ascii art like you did above.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java:99:
mInput.setInputType(InputType.TYPE_CLASS_PHONE);
TYPE_CLASS_PHONE?  is that just to limit it to numbers?

[please use gerrit instead, 2016-07-13 21:13:52]

Patch 4 screenshots in http://crbug.com/624924#c5.

[gone, 2016-07-13 21:17:59]

Also: resources are labeled "ic_whatever" because of Android convention for
icons.  I guess pr_whatever is alright for identifying payment request things?

[commit-bot: I haz the power, 2016-07-13 22:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 22:15:24]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-07-14 01:08:18]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 01:08:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-07-14 01:11:30]

Patchset #5 (id:430001) has been deleted

[commit-bot: I haz the power, 2016-07-14 01:12:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[please use gerrit instead, 2016-07-14 01:13:09]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 01:14:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 02:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 02:23:53]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-07-14 17:16:52]

Patchset #5 (id:450001) has been deleted

[please use gerrit instead, 2016-07-14 17:17:17]

Patchset #4 (id:410001) has been deleted

[please use gerrit instead, 2016-07-14 17:19:37]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 17:19:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-07-14 17:21:44]

dfalcantara@, ptal patch 4.

On 2016/07/13 21:17:59, dfalcantara wrote:
> Also: resources are labeled "ic_whatever" because of Android convention for
> icons.  I guess pr_whatever is alright for identifying payment request things?

Should be alright. UX originally sent me these images named
pr-${type}-${size}.png, so I renamed them into drawable-${size}/pr_${type}.png
without thinking about renaming "pr" into something more descriptive.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File chrome/android/java/res/layout/payment_request_editor_icons.xml (right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_icons.xml:26:
android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding">
On 2016/07/13 21:12:59, dfalcantara wrote:
> Just use /> instead of adding the other closing LinearLayout tag.

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File chrome/android/java/res/layout/payment_request_editor_label.xml (right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_label.xml:10:
android:paddingBottom="@dimen/pref_autofill_content_spacing"
On 2016/07/13 21:12:59, dfalcantara wrote:
> Use margins when separating items from other items, not padding.  This
currently
> knocks the icon off-center.

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_label.xml:19:
android:importantForAccessibility="no"
On 2016/07/13 21:12:59, dfalcantara wrote:
> Group the android:layout_ attributes together

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_label.xml:27:
android:layout_alignParentStart="true"
On 2016/07/13 21:12:59, dfalcantara wrote:
> Should this add layout_alignParentTop="true"?

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:358:
public CreditCard() {
On 2016/07/13 21:12:59, dfalcantara wrote:
> Make this constructor call the other one.
> 
> this("", AutofillPreferences.SETTINGS_ORIGIN, true, true, "", "", "", "", "",
> "", 0, "");

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:50:
/** All card types recognized by this editor. This is a subset of card types in
On 2016/07/13 21:12:59, dfalcantara wrote:
> Full Javadocs don't have sentences on the same line as the /**.  See what you
> did for the class comment and do that here.

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:91:
* @param webContents     The web contents where the web payments API is invoked.
Should not be
On 2016/07/13 21:13:00, dfalcantara wrote:
> Probably don't need to say "Should not be null" given taht you've got the
> asserts and @Nullable annotation for the ones that can be.

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:106:
mCardTypes = new HashSet<>();
On 2016/07/13 21:13:00, dfalcantara wrote:
> Makes more sense to have a HashMap containing CardInfos, where each CardInfo
> stores drawable IDs and descriptions.  The HashSet functionality in your CL
will
> be automatic given the HashMap has unique keys, and will avoid having to add
> asserts for size equality.

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:184:
private EditorFieldValidator getCardNumberValidator() {
On 2016/07/13 21:12:59, dfalcantara wrote:
> Make mCardNumberValidator final and create this in the constructor?  Avoids
> having to do the "== null" check each time you grab it.

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:237:

On 2016/07/13 21:13:00, dfalcantara wrote:
> Given how often you do toEdit == null, you should just save a
> 
> boolean isNewCard = (toEdit == null);

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:240:
final AutofillPaymentInstrument instrument = toEdit == null
On 2016/07/13 21:13:00, dfalcantara wrote:
> really hard to parse; put (toEdit == null ? ....);

Should be better after using isNewCard.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:247:
? R.string.autofill_create_credit_card : R.string.autofill_edit_credit_card));
On 2016/07/13 21:13:00, dfalcantara wrote:
> indentation

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:251:
// The calendar is required only for local cards. Error out if it's not ready.
On 2016/07/13 21:13:00, dfalcantara wrote:
> Can't you save the AsyncTask and then do a .get() on it to wait until it's
> finished and return the Calendar?  Beats erroring out.

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:398:
Calendar calendar, String alwaysIncludeYear) {
On 2016/07/13 21:13:00, dfalcantara wrote:
> Use: alwaysIncludedYear
> 
> "alwaysIncludeYear" sounds like a boolean.

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:432:
billingAddresses.add(new DropdownKeyValue("",
On 2016/07/13 21:13:00, dfalcantara wrote:
> pull "" into a constant instead of just commenting about it

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:453:
billingAddresses.add(new DropdownKeyValue("add",
On 2016/07/13 21:13:00, dfalcantara wrote:
> pull "add" into a constant

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:72:
void onPaymentRequestServiceProcessBillingAddressChange();
On 2016/07/13 21:13:00, dfalcantara wrote:
> Changed?

onPaymentRequestServiceBillingAddressChangeProcessed(), because this is a
notification that a change in billing address has been processed.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:111:
* @param label    Label.
On 2016/07/13 21:13:00, dfalcantara wrote:
> top label, middle label, bottom label?  sub implies that it's already below
the
> regular label, but not necessarily where it is relative to midlabel

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java:22:
private static final int LIST_ICON_SIZE_DP = 38;
On 2016/07/13 21:13:01, dfalcantara wrote:
> Add this to dimens.xml with the other payments dimensions.  Doing
> context.getDimensionPixelSize() on that dimension will give you what you then
> want instead of doing the crazy calculations on your own

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java:27:
* Builds a horizontal list of icons.
On 2016/07/13 21:13:00, dfalcantara wrote:
> I'm slightly worried about what will happen here when there are too many icons
> to fit on screen.  Do they just run off the side?

They would run off the screen. Android does not have a "flow" layout,
unfortunately. Lucky for us, we have at most 7 icons to show. At 38dp, all of
them fit even on Nexus 4 screen, according to my tests.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java:48:
icon.setMaxWidth((int) (LIST_ICON_SIZE_DP * scale + 0.5f));
On 2016/07/13 21:13:00, dfalcantara wrote:
> Math.round(LIST_ICON_SIZE_DP * scale)

No longer relevant after placing the size into dimens.xml file.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorLabelField.java:16:
* Helper class for creating a label view.
On 2016/07/13 21:13:01, dfalcantara wrote:
> Describe what a label is because it's more than just what I'd expect to be
> called a label.  Maybe draw ascii art like you did above.

Done.

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/390001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java:99:
mInput.setInputType(InputType.TYPE_CLASS_PHONE);
On 2016/07/13 21:13:01, dfalcantara wrote:
> TYPE_CLASS_PHONE?  is that just to limit it to numbers?

TYPE_CLASS_PHONE shows number keyboard with phone-related symbols. The filter
from above allows only digits, spaces, and "-" for credit card numbers.

Cannot use TYPE_CLASS_NUMBER here, because that has a built-in filter, which
filters out everything except digits and does not even allow the credit card
number formatter to alter the input field.

[please use gerrit instead, 2016-07-14 17:22:35]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Off by default, similar
   to how autofill always prompts the user for an explicit action to
   save a new card on disk.

BUG=624924
==========

to

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924
==========

[commit-bot: I haz the power, 2016-07-14 18:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 18:21:41]

Dry run: This issue passed the CQ dry run.

[gone, 2016-07-14 22:36:36]

lgtm, but it's admittedly hard to do a great review when it's so huge.

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
File chrome/android/java/res/layout/payment_request_editor_dropdown.xml (left):

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_dropdown.xml:28: 
Put the newline back; keeps it symmetric with the newline above.

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
File chrome/android/java/res/layout/payment_request_editor_icons.xml (right):

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_icons.xml:24:
android:layout_height="wrap_content" />
Same comment about final newlines as the other XML files

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
File chrome/android/java/res/layout/payment_request_editor_label.xml (right):

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
chrome/android/java/res/layout/payment_request_editor_label.xml:23:
android:id="@+id/topLabel"
top_label, mid_label, bottom_label

Convention is to use underscores for ids, which goes with the fact that all of
our layouts and resources have to have underscores (git grep "@+id")

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java:142:
mAddressFields.put(AddressField.LOCALITY, EditorFieldModel.createTextInput(0));
Consider making another constructor that doesn't take in a 0, which simply calls
the other constructor with a value that some INPUT_TYPE_HINT_NONE.

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:213:
invalidViews.get(0).scrollToAndFocus();
Kind of weird... should leave a comment about why you have to scroll down to the
first child of the layout.  Guessing this is because TextInputLayout has a
label?

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:437:
mCardInput.setFilters(new InputFilter[0]);  // Null is not allowed.
for clarity:

if (mCardInput != null) {
    mCardInput.removeTextChangedListener(mCardNumberFormatter);
    mCardInput.setFilters(new InputFilter[0]);  // Null is not allowed.
    mCardInput = null;
}

if (mPhoneInput != null) {
    mPhoneInput.removeTextChangedListener(mPhoneFormatter);
    mPhoneInput = null;
}

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
chrome/android/java/strings/android_chrome_strings.grd:2696: Card number
required
Wonder if it'd make sense to just say "Required field" instead of specializing
everything.  It's a lot of extra strings.

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
(right):

https://chromiumcodereview.appspot.com/2116583002/diff/470001/chrome/android/...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java:98:
triggerUIAndWait(mReadyToPay);
Given that these lines are repeated over and over again (with minor changes),
should you make a utility function for it?

[please use gerrit instead, 2016-07-15 00:22:07]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 00:22:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-07-15 00:24:36]

rouslan@chromium.org changed reviewers:
+ estade@chromium.org

[please use gerrit instead, 2016-07-15 00:24:37]

estade@, owners ptal components/resources/autofill_scaled_resources.grdp

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
File chrome/android/java/res/layout/payment_request_editor_dropdown.xml (left):

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
chrome/android/java/res/layout/payment_request_editor_dropdown.xml:28: 
On 2016/07/14 22:36:36, dfalcantara wrote:
> Put the newline back; keeps it symmetric with the newline above.

Done.

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
File chrome/android/java/res/layout/payment_request_editor_icons.xml (right):

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
chrome/android/java/res/layout/payment_request_editor_icons.xml:24:
android:layout_height="wrap_content" />
On 2016/07/14 22:36:36, dfalcantara wrote:
> Same comment about final newlines as the other XML files

Done.

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
File chrome/android/java/res/layout/payment_request_editor_label.xml (right):

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
chrome/android/java/res/layout/payment_request_editor_label.xml:23:
android:id="@+id/topLabel"
On 2016/07/14 22:36:36, dfalcantara wrote:
> top_label, mid_label, bottom_label
> 
> Convention is to use underscores for ids, which goes with the fact that all of
> our layouts and resources have to have underscores (git grep "@+id")

Done.

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
(right):

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java:142:
mAddressFields.put(AddressField.LOCALITY, EditorFieldModel.createTextInput(0));
On 2016/07/14 22:36:36, dfalcantara wrote:
> Consider making another constructor that doesn't take in a 0, which simply
calls
> the other constructor with a value that some INPUT_TYPE_HINT_NONE.

Done.

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
(right):

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:213:
invalidViews.get(0).scrollToAndFocus();
On 2016/07/14 22:36:36, dfalcantara wrote:
> Kind of weird... should leave a comment about why you have to scroll down to
the
> first child of the layout.  Guessing this is because TextInputLayout has a
> label?

Done.

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:437:
mCardInput.setFilters(new InputFilter[0]);  // Null is not allowed.
On 2016/07/14 22:36:36, dfalcantara wrote:
> for clarity:
> 
> if (mCardInput != null) {
>     mCardInput.removeTextChangedListener(mCardNumberFormatter);
>     mCardInput.setFilters(new InputFilter[0]);  // Null is not allowed.
>     mCardInput = null;
> }
> 
> if (mPhoneInput != null) {
>     mPhoneInput.removeTextChangedListener(mPhoneFormatter);
>     mPhoneInput = null;
> }

Done.

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/st...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:2696: Card number
required
On 2016/07/14 22:36:36, dfalcantara wrote:
> Wonder if it'd make sense to just say "Required field" instead of specializing
> everything.  It's a lot of extra strings.

Done, also reusing more of the autofill strings, to ease translators' burden.

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/javates...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
(right):

https://codereview.chromium.org/2116583002/diff/470001/chrome/android/javates...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java:98:
triggerUIAndWait(mReadyToPay);
On 2016/07/14 22:36:36, dfalcantara wrote:
> Given that these lines are repeated over and over again (with minor changes),
> should you make a utility function for it?

Done.

[commit-bot: I haz the power, 2016-07-15 02:57:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 02:57:26]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-07-15 22:03:35]

On 2016/07/15 00:24:37, Rouslan (ツ) wrote:
> estade@, owners ptal components/resources/autofill_scaled_resources.grdp
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
> File chrome/android/java/res/layout/payment_request_editor_dropdown.xml
(left):
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
> chrome/android/java/res/layout/payment_request_editor_dropdown.xml:28: 
> On 2016/07/14 22:36:36, dfalcantara wrote:
> > Put the newline back; keeps it symmetric with the newline above.
> 
> Done.
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
> File chrome/android/java/res/layout/payment_request_editor_icons.xml (right):
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
> chrome/android/java/res/layout/payment_request_editor_icons.xml:24:
> android:layout_height="wrap_content" />
> On 2016/07/14 22:36:36, dfalcantara wrote:
> > Same comment about final newlines as the other XML files
> 
> Done.
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
> File chrome/android/java/res/layout/payment_request_editor_label.xml (right):
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/re...
> chrome/android/java/res/layout/payment_request_editor_label.xml:23:
> android:id="@+id/topLabel"
> On 2016/07/14 22:36:36, dfalcantara wrote:
> > top_label, mid_label, bottom_label
> > 
> > Convention is to use underscores for ids, which goes with the fact that all
of
> > our layouts and resources have to have underscores (git grep "@+id")
> 
> Done.
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/sr...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
> (right):
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/sr...
>
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java:142:
> mAddressFields.put(AddressField.LOCALITY,
EditorFieldModel.createTextInput(0));
> On 2016/07/14 22:36:36, dfalcantara wrote:
> > Consider making another constructor that doesn't take in a 0, which simply
> calls
> > the other constructor with a value that some INPUT_TYPE_HINT_NONE.
> 
> Done.
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/sr...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
> (right):
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/sr...
>
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:213:
> invalidViews.get(0).scrollToAndFocus();
> On 2016/07/14 22:36:36, dfalcantara wrote:
> > Kind of weird... should leave a comment about why you have to scroll down to
> the
> > first child of the layout.  Guessing this is because TextInputLayout has a
> > label?
> 
> Done.
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/sr...
>
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:437:
> mCardInput.setFilters(new InputFilter[0]);  // Null is not allowed.
> On 2016/07/14 22:36:36, dfalcantara wrote:
> > for clarity:
> > 
> > if (mCardInput != null) {
> >     mCardInput.removeTextChangedListener(mCardNumberFormatter);
> >     mCardInput.setFilters(new InputFilter[0]);  // Null is not allowed.
> >     mCardInput = null;
> > }
> > 
> > if (mPhoneInput != null) {
> >     mPhoneInput.removeTextChangedListener(mPhoneFormatter);
> >     mPhoneInput = null;
> > }
> 
> Done.
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/st...
> File chrome/android/java/strings/android_chrome_strings.grd (right):
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/java/st...
> chrome/android/java/strings/android_chrome_strings.grd:2696: Card number
> required
> On 2016/07/14 22:36:36, dfalcantara wrote:
> > Wonder if it'd make sense to just say "Required field" instead of
specializing
> > everything.  It's a lot of extra strings.
> 
> Done, also reusing more of the autofill strings, to ease translators' burden.
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/javates...
> File
>
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
> (right):
> 
>
https://codereview.chromium.org/2116583002/diff/470001/chrome/android/javates...
>
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java:98:
> triggerUIAndWait(mReadyToPay);
> On 2016/07/14 22:36:36, dfalcantara wrote:
> > Given that these lines are repeated over and over again (with minor
changes),
> > should you make a utility function for it?
> 
> Done.

autofill scaled resources lgtm

[please use gerrit instead, 2016-07-15 22:04:29]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-07-15 22:04:30]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2116583002/#ps490001
(title: "Address dflacantara@'s final comments")

[commit-bot: I haz the power, 2016-07-15 22:05:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 22:11:27]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924
==========

to

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924
==========

[commit-bot: I haz the power, 2016-07-15 22:11:29]

Committed patchset #5 (id:490001)

[commit-bot: I haz the power, 2016-07-15 22:11:47]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 22:13:14]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924
==========

to

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924

Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Cr-Commit-Position: refs/heads/master@{#405876}
==========

[commit-bot: I haz the power, 2016-07-15 22:13:16]

Patchset 5 (id:??) landed as
https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Cr-Commit-Position: refs/heads/master@{#405876}

[Benoit L, 2016-07-18 09:27:38]

A revert of this CL (patchset #5 id:490001) has been created in
https://codereview.chromium.org/2158783002/ by lizeb@chromium.org.

The reason for reverting is: Broke Android Tests (dbg).

BUG=629011.

[markusheintz_, 2016-07-18 11:29:13]

A revert of this CL (patchset #5 id:490001) has been created in
https://codereview.chromium.org/2162493002/ by markusheintz@chromium.org.

The reason for reverting is: Android Test builder is failing since
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...

see
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...

This may be one of two CLs that could have caused this. The first one has been
reverted (https://codereview.chromium.org/2158763002) without any success
(https://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tes...)
now I'm trying this one too.
.

[please use gerrit instead, 2016-07-18 16:34:07]

We had a fix in http://crrev.com/2154123002, but it did not land in time. Will
fix and re-land shortly.

[please use gerrit instead, 2016-07-18 16:58:45]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924

Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Cr-Commit-Position: refs/heads/master@{#405876}
==========

to

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924

Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Cr-Commit-Position: refs/heads/master@{#405876}
==========

[please use gerrit instead, 2016-07-18 16:58:56]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-07-18 16:58:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
dfalcantara@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2116583002/#ps510001
(title: "Fix failing test")

[commit-bot: I haz the power, 2016-07-18 16:59:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 18:11:24]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924

Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Cr-Commit-Position: refs/heads/master@{#405876}
==========

to

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924

Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Cr-Commit-Position: refs/heads/master@{#405876}
==========

[commit-bot: I haz the power, 2016-07-18 18:11:26]

Committed patchset #6 (id:510001)

[commit-bot: I haz the power, 2016-07-18 18:11:38]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 18:13:24]

Description was changed from

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924

Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Cr-Commit-Position: refs/heads/master@{#405876}
==========

to

==========
Credit card editor for PaymentRequest UI.

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924

Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Committed: https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4
Cr-Original-Commit-Position: refs/heads/master@{#405876}
Cr-Commit-Position: refs/heads/master@{#406036}
==========

[commit-bot: I haz the power, 2016-07-18 18:13:26]

Patchset 6 (id:??) landed as
https://crrev.com/80b5895d9b722eba9129c62c1788f8cbef351dc4
Cr-Commit-Position: refs/heads/master@{#406036}