Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2135443002: DevTools: explicitly use debugger context when processing objects from DebuggerScript.js. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: explicitly use debugger context when processing objects from DebuggerScript.js. BUG= Committed: https://crrev.com/aa55ad395804cf21d2b1594289219eb63f8277a6 Cr-Commit-Position: refs/heads/master@{#404501}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -73 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 5 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js View 1 chunk +7 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 chunks +29 lines, -26 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
pfeldman
4 years, 5 months ago (2016-07-07 23:01:52 UTC) #2
dgozman
https://codereview.chromium.org/2135443002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt File third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt (left): https://codereview.chromium.org/2135443002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt#oldcode9 third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt:9: 0) window.removeIframe (pause-in-removed-frame.html:11) I think only frames from child.html ...
4 years, 5 months ago (2016-07-08 00:08:21 UTC) #5
pfeldman
https://codereview.chromium.org/2135443002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt File third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt (left): https://codereview.chromium.org/2135443002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt#oldcode9 third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/pause-in-removed-frame-expected.txt:9: 0) window.removeIframe (pause-in-removed-frame.html:11) On 2016/07/08 00:08:21, dgozman wrote: > ...
4 years, 5 months ago (2016-07-08 00:13:53 UTC) #6
pfeldman
PTAL
4 years, 5 months ago (2016-07-08 19:01:33 UTC) #7
dgozman
lgtm!
4 years, 5 months ago (2016-07-08 19:06:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135443002/20001
4 years, 5 months ago (2016-07-08 19:09:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 21:51:55 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 21:53:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa55ad395804cf21d2b1594289219eb63f8277a6
Cr-Commit-Position: refs/heads/master@{#404501}

Powered by Google App Engine
This is Rietveld 408576698