Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

Issue 2135443002: DevTools: explicitly use debugger context when processing objects from DebuggerScript.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 ~CallFrameScope(); 152 ~CallFrameScope();
153 size_t frameOrdinal() const { return m_frameOrdinal; } 153 size_t frameOrdinal() const { return m_frameOrdinal; }
154 private: 154 private:
155 void findInjectedScript(V8InspectorSessionImpl*) override; 155 void findInjectedScript(V8InspectorSessionImpl*) override;
156 String16 m_remoteCallFrameId; 156 String16 m_remoteCallFrameId;
157 size_t m_frameOrdinal; 157 size_t m_frameOrdinal;
158 }; 158 };
159 159
160 private: 160 private:
161 InjectedScript(InspectedContext*, v8::Local<v8::Object>, std::unique_ptr<Inj ectedScriptNative>); 161 InjectedScript(InspectedContext*, v8::Local<v8::Object>, std::unique_ptr<Inj ectedScriptNative>);
162 bool canAccessInspectedWindow() const;
163 v8::Local<v8::Value> v8Value() const; 162 v8::Local<v8::Value> v8Value() const;
164 v8::MaybeLocal<v8::Value> wrapValue(ErrorString*, v8::Local<v8::Value>, cons t String16& groupName, bool forceValueType, bool generatePreview) const; 163 v8::MaybeLocal<v8::Value> wrapValue(ErrorString*, v8::Local<v8::Value>, cons t String16& groupName, bool forceValueType, bool generatePreview) const;
165 v8::Local<v8::Object> commandLineAPI(); 164 v8::Local<v8::Object> commandLineAPI();
166 165
167 InspectedContext* m_context; 166 InspectedContext* m_context;
168 v8::Global<v8::Value> m_value; 167 v8::Global<v8::Value> m_value;
169 v8::Global<v8::Value> m_lastEvaluationResult; 168 v8::Global<v8::Value> m_lastEvaluationResult;
170 std::unique_ptr<InjectedScriptNative> m_native; 169 std::unique_ptr<InjectedScriptNative> m_native;
171 v8::Global<v8::Object> m_commandLineAPI; 170 v8::Global<v8::Object> m_commandLineAPI;
172 }; 171 };
173 172
174 } // namespace blink 173 } // namespace blink
175 174
176 #endif 175 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698