Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

Issue 2135443002: DevTools: explicitly use debugger context when processing objects from DebuggerScript.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
index bac0f5f7ecd7022ce78a0c5ae34e0eef0cd8a500..a1566eb1fcaf06f498945f27c4815d9030a46d33 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
@@ -213,72 +213,49 @@ InjectedScript.prototype = {
/**
* @param {*} object
* @param {string} groupName
- * @param {boolean} canAccessInspectedGlobalObject
* @param {boolean} forceValueType
* @param {boolean} generatePreview
* @return {!RuntimeAgent.RemoteObject}
*/
- wrapObject: function(object, groupName, canAccessInspectedGlobalObject, forceValueType, generatePreview)
+ wrapObject: function(object, groupName, forceValueType, generatePreview)
{
- if (canAccessInspectedGlobalObject)
- return this._wrapObject(object, groupName, forceValueType, generatePreview);
- return this._fallbackWrapper(object);
+ return this._wrapObject(object, groupName, forceValueType, generatePreview);
},
/**
* @param {!Array<!Object>} array
* @param {string} property
* @param {string} groupName
- * @param {boolean} canAccessInspectedGlobalObject
* @param {boolean} forceValueType
* @param {boolean} generatePreview
*/
- wrapPropertyInArray: function(array, property, groupName, canAccessInspectedGlobalObject, forceValueType, generatePreview)
+ wrapPropertyInArray: function(array, property, groupName, forceValueType, generatePreview)
{
for (var i = 0; i < array.length; ++i) {
if (typeof array[i] === "object" && property in array[i])
- array[i][property] = this.wrapObject(array[i][property], groupName, canAccessInspectedGlobalObject, forceValueType, generatePreview);
+ array[i][property] = this.wrapObject(array[i][property], groupName, forceValueType, generatePreview);
}
},
/**
* @param {!Array<*>} array
* @param {string} groupName
- * @param {boolean} canAccessInspectedGlobalObject
* @param {boolean} forceValueType
* @param {boolean} generatePreview
*/
- wrapObjectsInArray: function(array, groupName, canAccessInspectedGlobalObject, forceValueType, generatePreview)
+ wrapObjectsInArray: function(array, groupName, forceValueType, generatePreview)
{
for (var i = 0; i < array.length; ++i)
- array[i] = this.wrapObject(array[i], groupName, canAccessInspectedGlobalObject, forceValueType, generatePreview);
+ array[i] = this.wrapObject(array[i], groupName, forceValueType, generatePreview);
},
/**
- * @param {*} object
- * @return {!RuntimeAgent.RemoteObject}
- */
- _fallbackWrapper: function(object)
- {
- var result = { __proto__: null };
- result.type = typeof object;
- if (this.isPrimitiveValue(object))
- result.value = object;
- else
- result.description = toString(object);
- return /** @type {!RuntimeAgent.RemoteObject} */ (result);
- },
-
- /**
- * @param {boolean} canAccessInspectedGlobalObject
* @param {!Object} table
* @param {!Array.<string>|string|boolean} columns
* @return {!RuntimeAgent.RemoteObject}
*/
- wrapTable: function(canAccessInspectedGlobalObject, table, columns)
+ wrapTable: function(table, columns)
{
- if (!canAccessInspectedGlobalObject)
- return this._fallbackWrapper(table);
var columnNames = null;
if (typeof columns === "string")
columns = [columns];

Powered by Google App Engine
This is Rietveld 408576698