Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2135103002: Make the IPC OWNERS check a warning until landing (Closed)

Created:
4 years, 5 months ago by vabr (Chromium)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@413020_ssl_valid
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the IPC OWNERS check a warning until landing The _CheckIpcOwners check is currently an error even at non-submit time. This makes it hard to upload changes before the patch is ready for review. Following the discussion on the bug, this CL makes that check a warning unless it is happening at submit time, in which case it remains an error. BUG=625975 Committed: https://crrev.com/f5ce3bf9ba864291012a0d8998f1cf07d7508c16 Cr-Commit-Position: refs/heads/master@{#404657}

Patch Set 1 : Make the IPC OWNERS check a warning until landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
vabr (Chromium)
Hi Jochen, PTAL. dcheng@ seems to be OK with this plan in http://crbug.com/625975#c2. Cheers, Vaclav
4 years, 5 months ago (2016-07-11 06:41:08 UTC) #5
dcheng
non-owner LGTM (Thanks, I was about to write the same patch myself!)
4 years, 5 months ago (2016-07-11 06:51:00 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-11 14:36:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135103002/20001
4 years, 5 months ago (2016-07-11 14:48:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-11 14:52:53 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 14:52:58 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 14:54:53 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5ce3bf9ba864291012a0d8998f1cf07d7508c16
Cr-Commit-Position: refs/heads/master@{#404657}

Powered by Google App Engine
This is Rietveld 408576698