| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 1467 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1478 for pattern, entry in patterns.iteritems(): | 1478 for pattern, entry in patterns.iteritems(): |
| 1479 missing_lines.extend(entry['rules']) | 1479 missing_lines.extend(entry['rules']) |
| 1480 files.extend([' %s' % f.LocalPath() for f in entry['files']]) | 1480 files.extend([' %s' % f.LocalPath() for f in entry['files']]) |
| 1481 if missing_lines: | 1481 if missing_lines: |
| 1482 errors.append( | 1482 errors.append( |
| 1483 '%s is missing the following lines:\n\n%s\n\nfor changed files:\n%s' % | 1483 '%s is missing the following lines:\n\n%s\n\nfor changed files:\n%s' % |
| 1484 (owners_file, '\n'.join(missing_lines), '\n'.join(files))) | 1484 (owners_file, '\n'.join(missing_lines), '\n'.join(files))) |
| 1485 | 1485 |
| 1486 results = [] | 1486 results = [] |
| 1487 if errors: | 1487 if errors: |
| 1488 results.append(output_api.PresubmitError( | 1488 if input_api.is_committing: |
| 1489 output = output_api.PresubmitError |
| 1490 else: |
| 1491 output = output_api.PresubmitPromptWarning |
| 1492 results.append(output( |
| 1489 'Found changes to IPC files without a security OWNER!', | 1493 'Found changes to IPC files without a security OWNER!', |
| 1490 long_text='\n\n'.join(errors))) | 1494 long_text='\n\n'.join(errors))) |
| 1491 | 1495 |
| 1492 return results | 1496 return results |
| 1493 | 1497 |
| 1494 | 1498 |
| 1495 def _CheckAndroidToastUsage(input_api, output_api): | 1499 def _CheckAndroidToastUsage(input_api, output_api): |
| 1496 """Checks that code uses org.chromium.ui.widget.Toast instead of | 1500 """Checks that code uses org.chromium.ui.widget.Toast instead of |
| 1497 android.widget.Toast (Chromium Toast doesn't force hardware | 1501 android.widget.Toast (Chromium Toast doesn't force hardware |
| 1498 acceleration on low-end devices, saving memory). | 1502 acceleration on low-end devices, saving memory). |
| (...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 2214 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 2218 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| 2215 input_api, | 2219 input_api, |
| 2216 output_api, | 2220 output_api, |
| 2217 json_url='http://chromium-status.appspot.com/current?format=json')) | 2221 json_url='http://chromium-status.appspot.com/current?format=json')) |
| 2218 | 2222 |
| 2219 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2223 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 2220 input_api, output_api)) | 2224 input_api, output_api)) |
| 2221 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2225 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 2222 input_api, output_api)) | 2226 input_api, output_api)) |
| 2223 return results | 2227 return results |
| OLD | NEW |